Skip to content

[Config] EnumNode name cannot be null anymore #25046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MatTheCat opened this issue Nov 20, 2017 · 0 comments
Closed

[Config] EnumNode name cannot be null anymore #25046

MatTheCat opened this issue Nov 20, 2017 · 0 comments
Labels
BC Break Config

Comments

@MatTheCat
Copy link
Contributor

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Symfony version 4.0.0

aaf2265 removed the possibility for an EnumNode to have a null name. Now using enumPrototype results in

Type error: Argument 1 passed to Symfony\Component\Config\Definition\EnumNode::__construct() must be of the type string, null given, called in symfony/config/Definition/Builder/EnumNodeDefinition.php on line 54
@MatTheCat MatTheCat mentioned this issue Nov 20, 2017
Closed
nicolas-grekas added a commit that referenced this issue Nov 20, 2017
@nicolas-grekas
bug #25048 Allow EnumNode name to be null (MatTheCat)
a135690 
This PR was squashed before being merged into the 4.0-dev branch (closes #25048).

Discussion
----------

Allow EnumNode name to be null

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25046
| License       | MIT

Commits
-------

57d0636 Allow EnumNode name to be null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC Break Config
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicolas-grekas @MatTheCat @chalasr