Skip to content

[FrameworkBundle] Improve the lint:xliff command #26537

Closed
@javiereguiluz

Description

@javiereguiluz
Q A
Bug report? no
Feature request? yes
BC Break report? no
RFC? no
Symfony version 4.1

The lint:xliff command validates the XML syntax of the XLIFF translation files, but it's common to make other mistakes like the following:

 <!-- messages.fa.xlf -->
 <?xml version="1.0" encoding="utf-8"?>
 <xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" version="1.2">
-    <file source-language="en" target-language="en" datatype="plaintext" original="file.ext">
+    <file source-language="en" target-language="fa" datatype="plaintext" original="file.ext">

In my experience it's pretty common to forget update the target-language value and keep the original one (en in this case). So, could we improve lint:xliff to detect and report this error too? Question to translation and XLIFF experts:

  • Should we do this?
  • Is this really an error? The app works great even if target-language is wrong? Does Symfony ignore this? Is it on purpose or a bug too?
  • Are there other common XLIFF errors that we could fix too?

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions