Skip to content

bootstrap_4_layout.html.twig does not render form parent errors correctly after switching to span #26869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
normisg opened this issue Apr 9, 2018 · 0 comments
Closed

bootstrap_4_layout.html.twig does not render form parent errors correctly after switching to span #26869

normisg opened this issue Apr 9, 2018 · 0 comments
Labels
Bug Status: Needs Review TwigBridge

Comments

@normisg
Copy link

normisg commented Apr 9, 2018

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? yes
Symfony version 4.0.8

Bootstrap 4 layout does not render form parent errors correctly after switching to <span>

d-block class is missing after alert-danger
Commit: 5dcaaad

<span class="{% if form is not rootform %}invalid-feedback d-block{% else %}alert alert-danger{% endif %}">
@normisg normisg changed the title bootstrap_4_layout.html.twig parent alert block is displayed inline bootstrap_4_layout.html.twig does not render form parent errors correctly after switching to span Apr 9, 2018
@normisg normisg mentioned this issue Apr 10, 2018
Merged
nicolas-grekas added a commit that referenced this issue Apr 14, 2018
@nicolas-grekas
bug #26870 Add d-block to bootstrap 4 alerts (Normunds)
6bdaa40 
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #26870).

Discussion
----------

Add d-block to bootstrap 4 alerts

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #26869
| License       | MIT
| Doc PR        | N/A

Commits
-------

40bd8bd Add d-block to bootstrap 4 alerts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Status: Needs Review TwigBridge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nicolas-grekas @xabbuh @carsonbot @normisg