phpunit-bridge compatibility with phpunit v7.* #26931
Labels
Comments
|
@greg0ire maybe you'd like to have a look? |
|
@nicolas-grekas will do :) Fun fact: @juliendufresne is one of my new colleagues |
|
Running into this. Any fix pending? ./bin/phpunit -v Fatal error: Declaration of Symfony\Bridge\PhpUnit\TextUI\TestRunner::handleConfiguration(array &$arguments) must be compatible with PHPUnit\TextUI\TestRunner::handleConfiguration(array &$arguments): void in /srv/myapp/vendor/symfony/phpunit-bridge/TextUI/TestRunner.php on line 25 |
|
@geoff-maddock currently looking into it. |
greg0ire
added a commit
to greg0ire/symfony
that referenced
this issue
Apr 20, 2018
This makes classes inheriting from phpunit classes compatible with phpunit 7. Fixes symfony#26931
greg0ire
added a commit
to greg0ire/symfony
that referenced
this issue
Apr 21, 2018
This makes classes inheriting from phpunit classes compatible with phpunit 7. Fixes symfony#26931
greg0ire
added a commit
to greg0ire/symfony
that referenced
this issue
Apr 21, 2018
This makes classes inheriting from phpunit classes compatible with phpunit 7. Fixes symfony#26931
greg0ire
added a commit
to greg0ire/symfony
that referenced
this issue
Apr 21, 2018
This makes classes inheriting from phpunit classes compatible with phpunit 7. Fixes symfony#26931
greg0ire
added a commit
to greg0ire/symfony
that referenced
this issue
Apr 22, 2018
This makes classes inheriting from phpunit classes compatible with phpunit 7. Fixes symfony#26931
greg0ire
added a commit
to greg0ire/symfony
that referenced
this issue
Apr 22, 2018
This makes classes inheriting from phpunit classes compatible with phpunit 7. Fixes symfony#26931
nicolas-grekas
added a commit
that referenced
this issue
Apr 22, 2018
This PR was merged into the 3.4 branch. Discussion ---------- [PhpUnitBridge] Add type hints | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no (only changed classes marked as internal) | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26931 | License | MIT | Doc PR | n/a This makes classes inheriting from phpunit classes compatible with phpunit 7. Commits ------- 6fbcc51 Add type hints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since this commit of PHPUnit, PHPUnit has added return types to some methods.
This causes some compatibility issue when using PHPUnit version 7 or later and symfony/phpunit-bridge.
For example, the method
Symfony\Bridge\PhpUnit\TextUI\Command::createRunner()does not specify the return type.Output of `SYMFONY_PHPUNIT_VERSION=7.0 php vendor/bin/simple-phpunit`
PHP Fatal error: Declaration of Symfony\Bridge\PhpUnit\TextUI\Command::createRunner() must be compatible with PHPUnit\TextUI\Command::createRunner(): PHPUnit\TextUI\TestRunner in <path>/vendor/symfony/phpunit-bridge/TextUI/Command.php on line 24
The text was updated successfully, but these errors were encountered: