Skip to content

[DependencyInjection] Wrong error message when using bindings on a service with missing parents #27146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jvasseur opened this issue May 4, 2018 · 2 comments
Closed

[DependencyInjection] Wrong error message when using bindings on a service with missing parents #27146

jvasseur opened this issue May 4, 2018 · 2 comments
Labels
Bug DependencyInjection Status: Needs Review

Comments

@jvasseur
Copy link
Contributor

jvasseur commented May 4, 2018

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Symfony version 4.1

When you use bindings on a service with a missing parent class or interface you get the unused binding error which doesn't point to the real problem (a parent is missing).

This is probably related to #27088.
@nicolas-grekas
Copy link
Member

nicolas-grekas commented May 5, 2018 •
edited
Loading

Would you be able to debug why and provide a fix maybe? That'd be awesome :)
A reproducer we could fork otherwise?

@nicolas-grekas
Copy link
Member

see #27191

@nicolas-grekas nicolas-grekas mentioned this issue May 8, 2018
Merged
fabpot added a commit that referenced this issue May 12, 2018
@fabpot
bug #27191 [DI] Display previous error messages when throwing unused …
98934e4 
…bindings (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Display previous error messages when throwing unused bindings

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | n
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27146
| License       | MIT
| Doc PR        | -

As reported by @jvasseur, confirmation + review welcome.

Commits
-------

f2231b5 [DI] Display previous error messages when throwing unused bindings
@fabpot fabpot closed this as completed May 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug DependencyInjection Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fabpot @nicolas-grekas @jvasseur @xabbuh @carsonbot