Skip to content

[Form] Move abstract layout tests to twig bridge #27897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vudaltsov opened this issue Jul 8, 2018 · 1 comment
Closed

[Form] Move abstract layout tests to twig bridge #27897

vudaltsov opened this issue Jul 8, 2018 · 1 comment
Labels
Form RFC RFC = Request For Comments (proposals about features that you want to be discussed) TwigBridge

Comments

@vudaltsov
Copy link
Contributor

Currently we have abstract layout test classes in Symfony\Component\Form\Tests namespace. None of these classes is extended in the Symfony\Component\Form namespace. All tests are implemented in Symfony\Bridge\Twig namespace.

At the same time the templates for which these abstract tests are designed also live in TwigBridge.

Because of this after any change in templates we have to adjust requirements in symfony/twig-bridge for deps=high and deps=low to pass.

I suggest moving abstract tests to TwigBridge. As far as I know, tests are considered internal, so this won't be a BC break.
@xabbuh xabbuh added Form RFC RFC = Request For Comments (proposals about features that you want to be discussed) TwigBridge labels Jul 8, 2018
@xabbuh
Copy link
Member

xabbuh commented Jul 9, 2018

We cannot move all those classes as FormHelperDivLayoutTest and FormHelperTableLayoutTest from the FrameworkBundle depend on the AbstractLayoutTest too. Though we can move the theme specific test classes to the Twig bridge.

@nicolas-grekas nicolas-grekas mentioned this issue Jul 23, 2018
Merged
nicolas-grekas added a commit that referenced this issue Jul 23, 2018
@nicolas-grekas
minor #28036 [TwigBridge][Form] fix tests by moving AbstractBootstrap…
ad31667 
…* cases to the bridge (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[TwigBridge][Form] fix tests by moving AbstractBootstrap* cases to the bridge

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27897
| License       | MIT
| Doc PR        | -

Commits
-------

8869b29 [TwigBridge][Form] fix tests by moving AbstractBootstrap* cases to the bridge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Form RFC RFC = Request For Comments (proposals about features that you want to be discussed) TwigBridge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicolas-grekas @xabbuh @vudaltsov