[DI] ServiceContainer build error after upgrading to 4.1.4 #28296

mmarton · 2018-08-28T13:43:56Z

Symfony version(s) affected: 4.1.4

Description

After upgrading to v4.1.4 the following error shown when container tries to build.

RuntimeException Cannot dump definitions which have method calls.

Tace

RuntimeException Cannot dump definitions which have method calls. [Symfony\Component\DependencyInjection\Exception\RuntimeException] Cannot dump definitions which have method calls.

Exception trace:
Symfony\Component\DependencyInjection\Dumper\PhpDumper->dumpValue() at /var/www/html/vendor/symfony/dependency-injection/Dumper/PhpDumper.php:614
Symfony\Component\DependencyInjection\Dumper\PhpDumper->addServiceMethodCalls() at /var/www/html/vendor/symfony/dependency-injection/Dumper/PhpDumper.php:516
Symfony\Component\DependencyInjection\Dumper\PhpDumper->addServiceInlinedDefinitions() at /var/www/html/vendor/symfony/dependency-injection/Dumper/PhpDumper.php:792
Symfony\Component\DependencyInjection\Dumper\PhpDumper->addService() at /var/www/html/vendor/symfony/dependency-injection/Dumper/PhpDumper.php:827
Symfony\Component\DependencyInjection\Dumper\PhpDumper->addServices() at /var/www/html/vendor/symfony/dependency-injection/Dumper/PhpDumper.php:194
Symfony\Component\DependencyInjection\Dumper\PhpDumper->dump() at /var/www/html/vendor/symfony/http-kernel/Kernel.php:704
Symfony\Component\HttpKernel\Kernel->dumpContainer() at /var/www/html/vendor/symfony/http-kernel/Kernel.php:541
Symfony\Component\HttpKernel\Kernel->initializeContainer() at /var/www/html/vendor/symfony/http-kernel/Kernel.php:123
Symfony\Component\HttpKernel\Kernel->boot() at /var/www/html/vendor/symfony/framework-bundle/Console/Application.php:65
Symfony\Bundle\FrameworkBundle\Console\Application->doRun() at /var/www/html/vendor/symfony/console/Application.php:145
Symfony\Component\Console\Application->run() at /var/www/html/bin/console:39

possibly BC break
possibly caused by: #28060
(or maybe i missed something and used it wrong)

How to reproduce
I have a monolog handler that requires EntityManagerInterface and a doctrine EventSubscriber that needs the monolog logger with the handler. It works fine when I downgrade to symfony/dependency-injection to v4.1.3

Files that requre to reproduce:

src/Monolog/DoctrineDBHandler.php

namespace App\Monolog;

use Doctrine\ORM\EntityManagerInterface;
use Monolog\Handler\AbstractProcessingHandler;

class DoctrineDBHandler extends AbstractProcessingHandler
{
    private $entityManager;

    public function __construct(EntityManagerInterface $em)
    {
        parent::__construct();
        $this->entityManager = $em;
    }

    protected function write(array $record): void
    {
        // write log to db
    }
}

src/EventSubscriber/DoctrineLogSubscriber.php

namespace App\EventSubscriber;

use Doctrine\Common\EventSubscriber;
use Doctrine\ORM\Event\LifecycleEventArgs;
use Monolog\Logger;

class DoctrineLogSubscriber implements EventSubscriber
{
    private $logger;

    public function __construct(Logger $logger)
    {
        $this->logger = $logger;
    }

    public function getSubscribedEvents(): array
    {
        return ['postPersist'];
    }

    public function postPersist(LifecycleEventArgs $args): void
    {
        $this->logger->addInfo('create');
    }
}

config/services.yaml

parameters:
    locale: 'en'

services:
    _defaults:
        autowire: true
        autoconfigure: true
        public: false

    App\:
        resource: '../src/*'
        exclude: '../src/{DependencyInjection,Entity,Migrations,Tests,Kernel.php}'

    App\DoctrineLogSubscriber:
        arguments: ['@monolog.logger.demo']
        tags:
            - { name: doctrine.event_subscriber }

config/packages/dev/monolog.yaml

...
monolog:
    channels: ['demo']
    handlers:
        main:
            type: stream
            path: "%kernel.logs_dir%/%kernel.environment%.log"
            level: debug
            channels: ["!event"]
        console:
            type: console
            process_psr_3_messages: false
            channels: ["!event", "!doctrine", "!console"]
        demo:
            channels: ['demo']
            level: INFO
            type: service
            id: App\Monolog\DoctrineDBHandler

nicolas-grekas · 2018-08-28T13:51:51Z

Hello, thanks for the report.
Can you please create a small app app we could clone to reproduce the issue? That would help a lot. Thanks.

mmarton · 2018-08-28T14:05:40Z

Hello.
It's here: https://github.com/mmarton/symfony-di-error-poc

codedmonkey · 2018-08-28T14:48:22Z

We have this problem in 3.4.15, I'll check if I can work out a small reproduction too.

dmaicher · 2018-08-28T18:11:48Z

@nicolas-grekas seems its indeed caused by #28060

for some service definitions with method-calls this condition + continue here now prevents them from being added to $this->definitionVariables:

https://github.com/symfony/symfony/pull/28060/files#diff-f7b23d463cba27ac5e4cb677f2be7623R509

So they are not dumped here:

https://github.com/nicolas-grekas/symfony/blob/e843bb86c88c9a52a6c9d3a98afb11f796624abe/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php#L1767

Which leads to the Exception. Unfortunately I don't fully understand all that logic so I cannot fix it 😄 🙈

Webonaute · 2018-08-28T18:12:01Z

Also have some issue. if services have calls method but are public: false, it throw exception.

franzwilding · 2018-08-30T08:46:46Z

Can confirm, that a simple composer require symfony/dependency-injection:4.1.3 solves the problem for the moment.

…y/symfony#28296 that causes application build to fail

nicolas-grekas · 2018-09-03T15:04:07Z

It looks like composer require symfony/proxy-manager-bridge fixes the issue.

ghost · 2018-09-03T15:15:59Z

@nicolas-grekas

composer require symfony/proxy-manager-bridge
composer show | grep symfony/ | egrep "dependency|proxy"
	symfony/dependency-injection             v4.1.4     Symfony DependencyInjection Component
	symfony/proxy-manager-bridge             v4.1.4     Symfony ProxyManager Bridge

composer update
	Loading composer repositories with package information
	Updating dependencies (including require-dev)
	Package operations: 0 installs, 1 update, 0 removals
	Generating autoload files
	ocramius/package-versions:  Generating version class...
	ocramius/package-versions: ...done generating version class

	Executing script cache:clear [KO]
	 [KO]
	Script cache:clear returned with error code 1
	!!
	!!  In PhpDumper.php line 1543:
	!!
	!!    Cannot dump definitions which have method calls.
	!!
	!!
	!!
	Script @auto-scripts was called via post-update-cmd

mmarton · 2018-09-03T15:19:13Z

It fixes my original problem. I'm just not sure, that adding a new dependency is the right way to fix a bug introduced in a patch release.

ghost · 2018-09-03T15:26:12Z

@mmarton

You no longer see the "Cannot dump ..." error?

Did you in-fact also remove the DI 4.1.3 instance, allowing update back to 4.1.4?

mmarton · 2018-09-03T15:30:02Z

@hal869

yes, it fixes my demo repository here: https://github.com/mmarton/symfony-di-error-poc

$ bin/console cache:clear
// Clearing the cache for the dev environment with debug true
[OK] Cache for the "dev" environment (debug=true) was successfully cleared.

$ composer show | grep symfony/ | egrep "dependency|proxy"
symfony/dependency-injection v4.1.4 Symfony DependencyInjection Component
symfony/proxy-manager-bridge v4.1.4 Symfony ProxyManager Bridge

ghost · 2018-09-03T15:33:13Z

@mmarton

yes, it fixes my demo repository

well, then, hm :-/ still 'here', clearly. poking around for 'why' ...

p.s.
and

I'm just not sure, that adding a new dependency is the right way to fix a bug introduced in a patch release.

generally agree

fmata · 2018-09-03T15:58:17Z

I can confirm that requiring symfony/proxy-manager-bridge fixes the issue.

ghost · 2018-09-03T17:21:11Z

@nicolas-grekas

https://github.com/hal869/symfony-28296.git

composer show | egrep "dependency-injection|proxy-manager-bridge"
	symfony/dependency-injection             v4.1.4             Symfony DependencyInjectio...
	symfony/proxy-manager-bridge             v4.1.4             Symfony ProxyManager Bridge

composer update
	...
	Executing script cache:clear [KO]
	 [KO]
	Script cache:clear returned with error code 1
	!!
	!!  In PhpDumper.php line 1543:
	!!
	!!    Cannot dump definitions which have method calls.
	!!
	!!
	!!
	Script @auto-scripts was called via post-update-cmd

and

composer require symfony/dependency-injection:4.1.3
composer show | egrep "dependency-injection|proxy-manager-bridge"
	symfony/dependency-injection             v4.1.3             Symfony DependencyInjectio...
	symfony/proxy-manager-bridge             v4.1.4             Symfony ProxyManager Bridge
composer update
	...
	(no error)

frostieDE · 2018-09-03T18:46:53Z

I cannot confirm that composer require symfony/proxy-manager-bridge fixes the problem:

PS D:\Dev\Web\idp> composer require symfony/proxy-manager-bridge
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
  - Installing symfony/proxy-manager-bridge (v4.1.4): Downloading (100%)
Writing lock file
Generating autoload files
Endroid Installer detected project type "symfony"
- Configuring endroid/qr-code-bundle
ocramius/package-versions:  Generating version class...
ocramius/package-versions: ...done generating version class
Executing script cache:clear [KO]
 [KO]
Script cache:clear returned with error code 1
!!
!!  In PhpDumper.php line 1543:
!!
!!    Cannot dump definitions which have method calls.
!!
!!
!!

PHP config:

PHP 7.2.8 (cli) (built: Jul 21 2018 03:45:17) ( NTS MSVC15 (Visual C++ 2017) x64 )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.2.0, Copyright (c) 1998-2018 Zend Technologies

nicolas-grekas · 2018-09-03T19:28:41Z

Thanks to the reproducer, I managed to reduce the reproducer to a config like:

services:
    foo:
        class: c
        public: true
        arguments:
            - '@bar'
            - !service
                class: c
                properties:
                    p: !service
                        class: c
                        properties:
                            p: !service
                                class: c

    bar:
        class: c
        public: true
        properties:
            p: !service
                class: c
                arguments: ['@foo']

Indirectly related to proxy-manager indeed. On it now...

nicolas-grekas · 2018-09-04T20:47:41Z

Can you please report if applying #28366 fixes your issue?

ghost · 2018-09-04T21:38:16Z

@nicolas-grekas

cd /dev/web/test/
rm -rf *
git clone https://github.com/hal869/symfony-28296.git

cd symfony-28296
composer install
	...
	Executing script cache:clear [KO]
	 [KO]
	Script cache:clear returned with error code 1
	!!
	!!  In PhpDumper.php line 1543:
	!!
	!!    Cannot dump definitions which have method calls.
	!!
	!!
	!!
	Script @auto-scripts was called via post-install-cmd

composer show | egrep "dependency"
	symfony/dependency-injection             v4.1.4             Symfony DependencyInjectio...

git remote add nicolas-grekas-di-fix https://github.com/nicolas-grekas/symfony.git
git fetch nicolas-grekas-di-fix
git cherry-pick eca5db996d750267e0d0d123439fa4c6f7471bcc
git add -A
git commit -m "28296-di-fix"
git log | head
	commit 8c9eb20e77e444dd790be49c3e4afe3bc9a682b9
	Author: Nicolas Grekas <nicolas.grekas@gmail.com>
	Date:   Tue Sep 4 09:23:21 2018 +0200

	    28296-di-fix

composer update
	Executing script cache:clear [KO]
	 [KO]
	Script cache:clear returned with error code 1
	!!
	!!  In FileLoader.php line 168:
	!!
	!!    The autoloader expected class "App\Symfony\Component\DependencyInjection\Du
	!!    mper\PhpDumper" to be defined in file "/dev/web/test/symfony-28296/ven
	!!    dor/composer/../../src/Symfony/Component/DependencyInjection/Dumper/PhpDump
	!!    er.php". The file was found but the class was not in it, the class name or
	!!    namespace probably has a typo in /dev/web/test/symfony-28296/config/se
	!!    rvices.yaml (which is loaded in resource "/dev/web/test/symfony-28296/
	!!    config/services.yaml").
	!!
	!!
	!!  In DebugClassLoader.php line 288:
	!!
	!!    The autoloader expected class "App\Symfony\Component\DependencyInjection\Du
	!!    mper\PhpDumper" to be defined in file "/dev/web/test/symfony-28296/ven
	!!    dor/composer/../../src/Symfony/Component/DependencyInjection/Dumper/PhpDump
	!!    er.php". The file was found but the class was not in it, the class name or
	!!    namespace probably has a typo.
	!!
	!!
	!!
	Script @auto-scripts was called via post-update-cmd

nicolas-grekas · 2018-09-05T07:20:01Z

@hal869 this must be related to some issue when applying the patch.

This PR was merged into the 3.4 branch. Discussion ---------- [DI] Fix dumping some complex service graphs | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28296 (and its duplicates #28355 & #28362 ~+ possibly #28304~) | License | MIT | Doc PR | - Commits ------- 769fd4b [DI] Fix dumping some complex service graphs

alexislefebvre · 2018-09-16T20:36:51Z

requiring symfony/proxy-manager-bridge

didn't worked for me, I blacklisted the 4.1.4 version of symfony/dependency-injection and it worked:

"symfony/dependency-injection": "^4.1 <4.1.4"

See liip/LiipFunctionalTestBundle#448 for an example.

matheusdallrosa · 2018-09-18T13:13:01Z

Also have some issue. if services have calls method but are public: false, it throw exception.

I'm using Symfony 3.4 and this do not solved my problem. I have no service with this properties, but i keep getting the error:

  In PhpDumper.php line 1761:                                                
                                                                             
    Cannot dump definitions which have method calls.

I'll keep on 3.4.14.

nicolas-grekas · 2018-09-18T13:26:51Z

This is solved but not tagged.

mnavarrocarter · 2018-09-27T01:45:37Z

I have this very same problem. I donwgraded to the symfony/dependency-injection 4.1.3 but to no avail. Building the container just consumed my 15gb or RAM. The guilty service is a Doctrine Event Subscriber. When I comment it out of my service definitions, then everything works fine.

…y/symfony#28296 that causes application build to fail

mmarton changed the title ~~ServiceContainer build error after upgrading to 4.1.4~~ [DI] ServiceContainer build error after upgrading to 4.1.4 Aug 28, 2018

xabbuh added DependencyInjection Bug labels Aug 29, 2018

carsonbot added the Status: Needs Review label Aug 29, 2018

xsuntel mentioned this issue Aug 29, 2018

a client service or alias has been removed php-http/documentation#240

Closed

franzwilding added a commit to unite-cms/unite-cms that referenced this issue Aug 30, 2018

fix: Temporarily downgrade DI to 4.1.3 because of symfony/symfony#28296

c45c3c5

vitek-rostislav added a commit to shopsys/shopsys that referenced this issue Aug 30, 2018

Symfony >=3.4.15 marked as conflicting in composer.json due to symfon…

cab6b47

…y/symfony#28296 that causes application build to fail

vitek-rostislav mentioned this issue Aug 30, 2018

[shopsys] fix: Symfony >=3.4.15 marked as conflicting in composer.json shopsys/shopsys#436

Merged

vitek-rostislav added a commit to shopsys/shopsys that referenced this issue Aug 30, 2018

Symfony >=3.4.15 marked as conflicting in composer.json due to symfon…

d0cec5b

…y/symfony#28296 that causes application build to fail

vitek-rostislav added a commit to shopsys/shopsys that referenced this issue Aug 30, 2018

Symfony >=3.4.15 marked as conflicting in composer.json due to symfon…

d42df86

…y/symfony#28296 that causes application build to fail

vitek-rostislav added a commit to shopsys/shopsys that referenced this issue Aug 30, 2018

Symfony >=3.4.15 marked as conflicting in composer.json due to symfon…

7c8c18a

…y/symfony#28296 that causes application build to fail

MattCzerner pushed a commit to shopsys/framework that referenced this issue Aug 30, 2018

Symfony >=3.4.15 marked as conflicting in composer.json due to symfon…

8637282

…y/symfony#28296 that causes application build to fail

MattCzerner pushed a commit to shopsys/product-feed-zbozi that referenced this issue Aug 30, 2018

Symfony >=3.4.15 marked as conflicting in composer.json due to symfon…

db9feda

…y/symfony#28296 that causes application build to fail

MattCzerner pushed a commit to shopsys/product-feed-google that referenced this issue Aug 30, 2018

Symfony >=3.4.15 marked as conflicting in composer.json due to symfon…

da26016

…y/symfony#28296 that causes application build to fail

MattCzerner pushed a commit to shopsys/product-feed-heureka that referenced this issue Aug 30, 2018

Symfony >=3.4.15 marked as conflicting in composer.json due to symfon…

1e15d0c

…y/symfony#28296 that causes application build to fail

MattCzerner pushed a commit to shopsys/product-feed-heureka-delivery that referenced this issue Aug 30, 2018

Symfony >=3.4.15 marked as conflicting in composer.json due to symfon…

a0ff0e0

…y/symfony#28296 that causes application build to fail

MattCzerner pushed a commit to shopsys/http-smoke-testing that referenced this issue Aug 30, 2018

Symfony >=3.4.15 marked as conflicting in composer.json due to symfon…

c46f954

…y/symfony#28296 that causes application build to fail

MattCzerner pushed a commit to shopsys/form-types-bundle that referenced this issue Aug 30, 2018

Symfony >=3.4.15 marked as conflicting in composer.json due to symfon…

072c65e

…y/symfony#28296 that causes application build to fail

MattCzerner pushed a commit to shopsys/migrations that referenced this issue Aug 30, 2018

Symfony >=3.4.15 marked as conflicting in composer.json due to symfon…

0b44215

…y/symfony#28296 that causes application build to fail

MattCzerner pushed a commit to shopsys/project-base that referenced this issue Aug 30, 2018

Symfony >=3.4.15 marked as conflicting in composer.json due to symfon…

1aa8c45

…y/symfony#28296 that causes application build to fail

xabbuh mentioned this issue Sep 4, 2018

Console is broken in Symfony 4.1.4 #28355

Closed

This was referenced Sep 4, 2018

Cannot dump definitions which have method calls. #28362

Closed

[DI] Fix dumping some complex service graphs #28366

Merged

fabpot closed this as completed Sep 5, 2018

franzwilding added a commit to unite-cms/standard that referenced this issue Sep 13, 2018

fix: Temporarily downgrade DI to 4.1.3 because of symfony/symfony#28296

1ddf01b

franzwilding mentioned this issue Sep 13, 2018

composer create-project fails unite-cms/unite-cms#250

Closed

alexislefebvre mentioned this issue Sep 16, 2018

[2.x] Allow static assert calls liip/LiipFunctionalTestBundle#447

Merged

nicolas-grekas mentioned this issue Sep 22, 2018

3.4.15 only: PhpDumper "Cannot dump definitions which have method calls." #28557

Closed

dbu mentioned this issue Sep 23, 2018

Cannot dump definitions which have method calls doctrine/DoctrinePHPCRBundle#329

Closed

ShopsysBot pushed a commit to shopsys/product-feed-heureka-delivery that referenced this issue Sep 22, 2023

Symfony >=3.4.15 marked as conflicting in composer.json due to symfon…

ce0719c

…y/symfony#28296 that causes application build to fail

ShopsysBot pushed a commit to shopsys/form-types-bundle that referenced this issue Sep 22, 2023

Symfony >=3.4.15 marked as conflicting in composer.json due to symfon…

c029709

…y/symfony#28296 that causes application build to fail

ShopsysBot pushed a commit to shopsys/migrations that referenced this issue Sep 22, 2023

Symfony >=3.4.15 marked as conflicting in composer.json due to symfon…

f30a859

…y/symfony#28296 that causes application build to fail

ShopsysBot pushed a commit to shopsys/product-feed-zbozi that referenced this issue Sep 22, 2023

Symfony >=3.4.15 marked as conflicting in composer.json due to symfon…

f5a4a10

…y/symfony#28296 that causes application build to fail

ShopsysBot pushed a commit to shopsys/product-feed-heureka that referenced this issue Sep 22, 2023

Symfony >=3.4.15 marked as conflicting in composer.json due to symfon…

c24a253

…y/symfony#28296 that causes application build to fail

ShopsysBot pushed a commit to shopsys/product-feed-google that referenced this issue Sep 22, 2023

Symfony >=3.4.15 marked as conflicting in composer.json due to symfon…

f809ecd

…y/symfony#28296 that causes application build to fail

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DI] ServiceContainer build error after upgrading to 4.1.4 #28296

[DI] ServiceContainer build error after upgrading to 4.1.4 #28296

mmarton commented Aug 28, 2018

nicolas-grekas commented Aug 28, 2018

mmarton commented Aug 28, 2018

codedmonkey commented Aug 28, 2018 •

edited

Loading

dmaicher commented Aug 28, 2018

Webonaute commented Aug 28, 2018

franzwilding commented Aug 30, 2018

nicolas-grekas commented Sep 3, 2018

ghost commented Sep 3, 2018

mmarton commented Sep 3, 2018

ghost commented Sep 3, 2018

mmarton commented Sep 3, 2018

ghost commented Sep 3, 2018 •

edited by ghost

Loading

fmata commented Sep 3, 2018

ghost commented Sep 3, 2018 •

edited by ghost

Loading

frostieDE commented Sep 3, 2018 •

edited

Loading

nicolas-grekas commented Sep 3, 2018

nicolas-grekas commented Sep 4, 2018

ghost commented Sep 4, 2018

nicolas-grekas commented Sep 5, 2018

alexislefebvre commented Sep 16, 2018 •

edited

Loading

matheusdallrosa commented Sep 18, 2018

nicolas-grekas commented Sep 18, 2018

mnavarrocarter commented Sep 27, 2018

[DI] ServiceContainer build error after upgrading to 4.1.4 #28296

[DI] ServiceContainer build error after upgrading to 4.1.4 #28296

Comments

mmarton commented Aug 28, 2018

nicolas-grekas commented Aug 28, 2018

mmarton commented Aug 28, 2018

codedmonkey commented Aug 28, 2018 • edited Loading

dmaicher commented Aug 28, 2018

Webonaute commented Aug 28, 2018

franzwilding commented Aug 30, 2018

nicolas-grekas commented Sep 3, 2018

ghost commented Sep 3, 2018

mmarton commented Sep 3, 2018

ghost commented Sep 3, 2018

mmarton commented Sep 3, 2018

ghost commented Sep 3, 2018 • edited by ghost Loading

fmata commented Sep 3, 2018

ghost commented Sep 3, 2018 • edited by ghost Loading

frostieDE commented Sep 3, 2018 • edited Loading

nicolas-grekas commented Sep 3, 2018

nicolas-grekas commented Sep 4, 2018

ghost commented Sep 4, 2018

nicolas-grekas commented Sep 5, 2018

alexislefebvre commented Sep 16, 2018 • edited Loading

matheusdallrosa commented Sep 18, 2018

nicolas-grekas commented Sep 18, 2018

mnavarrocarter commented Sep 27, 2018

codedmonkey commented Aug 28, 2018 •

edited

Loading

ghost commented Sep 3, 2018 •

edited by ghost

Loading

ghost commented Sep 3, 2018 •

edited by ghost

Loading

frostieDE commented Sep 3, 2018 •

edited

Loading

alexislefebvre commented Sep 16, 2018 •

edited

Loading