Skip to content

[Symfony/Finder] ignoreVCSIgnored to look for .gitignore in parent directory #30739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ahmedsbytes opened this issue Mar 28, 2019 · 3 comments
Closed

[Symfony/Finder] ignoreVCSIgnored to look for .gitignore in parent directory #30739

ahmedsbytes opened this issue Mar 28, 2019 · 3 comments
Labels
Feature Finder

Comments

@ahmedsbytes
Copy link

in Symfony/Finder component , ignoreVCSIgnored search for .gitignored file in the directory passed to in(). But that file may be present in a parent folder (a Symfony project often has all gitignore rules defined at the project root, even when ignoring nested files/folders) or in subdirectories (with rules applying only in the given subdirectory).

#30448 (comment)
@ahmedsbytes ahmedsbytes mentioned this issue Mar 28, 2019
Merged
@fabpot fabpot added Good first issue Ideal for your first contribution! (some Symfony experience may be required) and removed Good first issue Ideal for your first contribution! (some Symfony experience may be required) labels Aug 6, 2019
@fabpot
Copy link
Member

fabpot commented Aug 6, 2019

Not sure if that's easy to implement (especially when symlinks are involved).

@Jibbarth Jibbarth mentioned this issue Jul 5, 2020
Closed
@carsonbot
Copy link

Thank you for this suggestion.
There has not been a lot of activity here for a while. Would you still like to see this feature?

@ahmedsbytes
Copy link
Author

I created this as a follow up on the discussion on the initial implementation in case anyone wanted to do it
but I'm afraid this is hard to do and also I do not really need it
closing it

@carsonbot carsonbot removed the Stalled label Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Finder
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fabpot @ahmedsbytes @xabbuh @carsonbot