Skip to content

Profiler search does not allow search for IPv6 ip address with letters #31378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MarioHoberg opened this issue May 3, 2019 · 0 comments
Closed

Profiler search does not allow search for IPv6 ip address with letters #31378

MarioHoberg opened this issue May 3, 2019 · 0 comments
Assignees
@javiereguiluz
Labels
Bug Status: Needs Review WebProfilerBundle

Comments

@MarioHoberg
Copy link

Symfony version(s) affected: 4.2.7

Description
Letters are filtered from ip input in profilter search form, which renders search for IPv6 addresses almost useless.

How to reproduce
Go to profiler search and enter an IPv6 ip address that contains letters, such as 2003:a. The letter a is removed from the input and the search.
However, it is possible to search for such an ip address by passing ip=2003:a as query parameter.
@javiereguiluz javiereguiluz self-assigned this May 4, 2019
@javiereguiluz javiereguiluz mentioned this issue May 4, 2019
Merged
nicolas-grekas added a commit that referenced this issue May 5, 2019
@nicolas-grekas
bug #31380 [WebProfilerBundle] Don't filter submitted IP values (javi…
5453f3e 
…ereguiluz)

This PR was merged into the 3.4 branch.

Discussion
----------

[WebProfilerBundle] Don't filter submitted IP values

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #31378   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | -

I don't think we need to filter the value submitted by users in this case.

Commits
-------

29bd2ad [WebProfilerBundle] Don't filter submitted IP values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javiereguiluz javiereguiluz

Labels
Bug Status: Needs Review WebProfilerBundle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@javiereguiluz @nicolas-grekas @MarioHoberg @carsonbot