Skip to content

The parameter "templating.helper.code.file_link_format" has a dependency on a non-existent parameter "f&line=" #31431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Perf opened this issue May 8, 2019 · 2 comments

Comments

@Perf
Copy link

Perf commented May 8, 2019

Symfony version(s) affected: 4.3@dev

Description
Having this issue after upgrading from 4.2 to 4.3@dev

How to reproduce

  1. ensure php.ini contains:
xdebug.file_link_format = "phpstorm://open?file=%f&line=%l&/docker/path/to/app>/host/path/to/app"
  1. execute in running container with app :
bin/console debug:container
  1. get an Exception

In ParameterBag.php line 100:
The parameter "templating.helper.code.file_link_format" has a dependency on a non-existent parameter "f&line=".

Possible Solution
¯\_(ツ)_/¯

Additional context
framework.ide parameter is not configured in SF config.

@ro0NL
Copy link
Contributor

ro0NL commented May 8, 2019

i believe this will be fixed in #30930

@Perf
Copy link
Author

Perf commented May 9, 2019

Perfect, seems to be so!
Thanks @ro0NL for update!

nicolas-grekas added a commit that referenced this issue May 11, 2019
…'%' (lyrixx)

This PR was merged into the 4.3 branch.

Discussion
----------

[FrameworkBundle] Fixed issue when a parameter contains a '%'

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31431
| License       | MIT
| Doc PR        |

---

On my computer:
```
dump(get_cfg_var('xdebug.file_link_format'));
"subl://%f:%l"
```

When I ran `bin/console debug:config framework` I got this exception:

```

In ParameterBag.php line 100:

  [Symfony\Component\DependencyInjection\Exception\ParameterNotFoundException]
  The parameter "templating.helper.code.file_link_format" has a
dependency on a non-existent parameter "f:".

Exception trace:
 () at
/home/gregoire/dev/github.com/lyrixx/symfony/src/Symfony/Component/DependencyInjection/ParameterBag/ParameterBag.php:100
...
```

This issue was introduced [here](https://github.com/symfony/symfony/pull/27684/files#diff-b3847149480405e1de881530b4c75ab5L212) / cc @ro0NL

This PR does not really fix the issue: I'm able to debug the config, The
the `debug:container --env-vars` does not work anymore. How could we fix
both issue? cc @nicolas-grekas

Commits
-------

7bcd714 [FrameworkBundle] Fixed issue when a parameter container a '%'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants