[Serializer] Support denormalization of object with variadic constructor typed argument #31436

ajgarlag · 2019-05-09T07:15:52Z

Symfony version(s) affected: 3.4 up to 4.2

Description
When the AbstractNormalizer detects a constructor variadic argument, it ignores the type hint of the argument, so the deserialization process throws a TypeError.

How to reproduce

<?php
require __DIR__ . '/vendor/autoload.php';
use Symfony\Component\Serializer\Encoder\JsonEncoder;
use Symfony\Component\Serializer\Normalizer\ObjectNormalizer;
use Symfony\Component\Serializer\Serializer;

class OrderLine
{
    private $concept;

    public function __construct(string $concept)
    {
        $this->concept = $concept;
    }

    public function getConcept(): string
    {
        return $this->concept;
    }
}

class Order
{
    private $orderLines = [];

    public function __construct(OrderLine ...$orderLines)
    {
        $this->orderLines = $orderLines;
    }

    /** @return OrderLines[] */
    public function getOrderLines(): array
    {
        return $this->orderLines;
    }
}

$serializer = new Serializer([new ObjectNormalizer()], [new JsonEncoder()]);
$order = new Order(new OrderLine('A'), new OrderLine('B'));
$serializedOrder = $serializer->serialize($order, 'json');
echo $serializedOrder . PHP_EOL;
$deserializedOrder = $serializer->deserialize($serializedOrder, Order::class, 'json');
echo count($deserializedOrder->getOrderLines()) . PHP_EOL;

Expected output:

{"orderLines":[{"concept":"A"},{"concept":"B"}]}
2

Current output:

{"orderLines":[{"concept":"A"},{"concept":"B"}]}
PHP Fatal error:  Uncaught TypeError: Argument 1 passed to Order::__construct() must be an instance of OrderLine, array given in /tmp/lala/bug.php:26
Stack trace:
#0 [internal function]: Order->__construct(Array, Array)
#1 /tmp/lala/vendor/symfony/symfony/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php(387): ReflectionClass->newInstanceArgs(Array)
#2 /tmp/lala/vendor/symfony/symfony/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php(185): Symfony\Component\Serializer\Normalizer\AbstractNormalizer->instantiateObject(Array, 'Order', Array, Object(ReflectionClass), false, 'json')
#3 /tmp/lala/vendor/symfony/symfony/src/Symfony/Component/Serializer/Serializer.php(182): Symfony\Component\Serializer\Normalizer\AbstractObjectNormalizer->denormalize(Array, 'Order', 'json', Array)
#4 /tmp/lala/vendor/symfony/symfony/src/Symfony/Component/Serializer/Serializer.php(133): Symfony\Component\Serializer\Serializer->denormalize(Array, 'Order', 'json', Array)
#5 /tmp/lala/bug.php(42): Symfony\Component\ in /tmp/lala/bug.php on line 26

The text was updated successfully, but these errors were encountered:

…onstructor typed argument (ajgarlag) This PR was squashed before being merged into the 3.4 branch (closes #31438). Discussion ---------- [Serializer] Fix denormalization of object with variadic constructor typed argument | Q | A | ------------- | --- | Branch? | 3.4 up to 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31436 | License | MIT This PR adds a test to demonstrate the bug, and a fix to squash it. Commits ------- c8c3c56 [Serializer] Fix denormalization of object with variadic constructor typed argument

ajgarlag changed the title ~~Support denormalization of object with variadic constructor typed argument~~ [Serializer] Support denormalization of object with variadic constructor typed argument May 9, 2019

ajgarlag mentioned this issue May 9, 2019

[Serializer] Fix denormalization of object with variadic constructor typed argument #31438

Merged

xabbuh added Feature Serializer labels May 9, 2019

nicolas-grekas closed this as completed May 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Serializer] Support denormalization of object with variadic constructor typed argument #31436

[Serializer] Support denormalization of object with variadic constructor typed argument #31436

ajgarlag commented May 9, 2019

[Serializer] Support denormalization of object with variadic constructor typed argument #31436

[Serializer] Support denormalization of object with variadic constructor typed argument #31436

Comments

ajgarlag commented May 9, 2019