Skip to content

Serializer does not map basic non-string types correctly in XML and CSV #33849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mkrauser opened this issue Oct 4, 2019 · 5 comments · Fixed by #33850
Closed

Serializer does not map basic non-string types correctly in XML and CSV #33849

mkrauser opened this issue Oct 4, 2019 · 5 comments · Fixed by #33850
Labels
Bug Serializer Status: Needs Review

Comments

@mkrauser
Copy link
Contributor

mkrauser commented Oct 4, 2019

Symfony version(s) affected: 3.4, 4.4

Description
In XML and CSV, all values are represented the same way, it is not possible to determine if a value is intended to be a string, int, float or boolean.

If something with non string properties (int, float, bool) is deserialized, an error is thrown:

PHP Fatal error:  Uncaught Symfony\Component\Serializer\Exception\NotNormalizableValueException: The type of the "width" attribute for class "App\Entities\Building" must be one of "float" ("string" given). in ./symfony-collection-serializer-bug/Normalizer/AbstractObjectNormalizer.php:298
Stack trace:
#0 ./symfony-collection-serializer-bug/Normalizer/AbstractObjectNormalizer.php(202): Symfony\Component\Serializer\Normalizer\AbstractObjectNormalizer->validateAndDenormalize('App\\Entities\\Bu...', 'width', '10.1', 'xml', Array)
#1 ./symfony-collection-serializer-bug/Serializer.php(172): Symfony\Component\Serializer\Normalizer\AbstractObjectNormalizer->denormalize(Array, 'App\\Entities\\Bu...', 'xml', Array)
#2 ./symfony-collection-serializer-bug/Serializer.php(123): Symfony\Component\Serializer\Serializer->denormalize(Array, 'App\\Entities\\Bu...', 'xml', Array)
...

How to reproduce
I'll submit a PR with a failing test

Possible Solution
The values need to be converted cast to the expected type.

Additional context
Tested with php 7.2
@mkrauser mkrauser changed the title Symfony serializer does not map basic non-string types correctly in XML and CSV Serializer does not map basic non-string types correctly in XML and CSV Oct 4, 2019
mkrauser added a commit to mkrauser/symfony that referenced this issue Oct 4, 2019
@mkrauser
[Serializer] fix denormalization of basic property-types in XML and CSV
164bf56 
symfony#33849
@mkrauser mkrauser mentioned this issue Oct 4, 2019
Merged
mkrauser added a commit to mkrauser/symfony that referenced this issue Oct 4, 2019
@mkrauser
[Serializer] fix denormalization of basic property-types in XML and CSV
a9a50b9 
symfony#33849
mkrauser added a commit to mkrauser/symfony that referenced this issue Oct 4, 2019
@mkrauser
[Serializer] fix denormalization of basic property-types in XML and CSV
bbbac21 
symfony#33849
mkrauser added a commit to mkrauser/symfony that referenced this issue Oct 7, 2019
@mkrauser
[Serializer] fix denormalization of basic property-types in XML and CSV
b9257ed 
symfony#33849
mkrauser added a commit to mkrauser/symfony that referenced this issue Oct 7, 2019
@mkrauser
[Serializer] fix denormalization of basic property-types in XML and CSV
81360cb 
symfony#33849
@warslett
Copy link
Contributor

This is a massive problem which makes the Serializer component completely unusable with XML. We are required to handle XML content on our API so that it can integrate with legacy technology. Same problem in API Platform @dunglas

@warslett
Copy link
Contributor

https://github.com/api-platform/api-platform/issues/1299

@warslett warslett mentioned this issue Oct 18, 2019
Closed
@warslett
Copy link
Contributor

@mkrauser is this issue still moving? It's holding up the fix in API Platform. Let me know if you don't have time to finish it I'll pick it up in a separate PR.

@mkrauser
Copy link
Contributor Author

@warslett Yes, definitly!

mkrauser added a commit to mkrauser/symfony that referenced this issue Oct 24, 2019
@mkrauser
[Serializer] fix denormalization of basic property-types in XML and CSV
823e177 
symfony#33849
mkrauser added a commit to mkrauser/symfony that referenced this issue Oct 24, 2019
@mkrauser
[Serializer] fix denormalization of basic property-types in XML and CSV
527ea03 
symfony#33849
mkrauser added a commit to mkrauser/symfony that referenced this issue Oct 24, 2019
@mkrauser
[Serializer] fix denormalization of basic property-types in XML and CSV
a6157bd 
symfony#33849
mkrauser added a commit to mkrauser/symfony that referenced this issue Oct 24, 2019
@mkrauser
[Serializer] fix denormalization of basic property-types in XML and CSV
98105f5 
symfony#33849
mkrauser added a commit to mkrauser/symfony that referenced this issue Nov 12, 2019
@mkrauser
[Serializer] fix denormalization of basic property-types in XML and CSV
628be3c 
symfony#33849
mkrauser added a commit to mkrauser/symfony that referenced this issue Nov 12, 2019
@mkrauser
[Serializer] fix denormalization of basic property-types in XML and CSV
608494f 
symfony#33849
mkrauser added a commit to mkrauser/symfony that referenced this issue Nov 12, 2019
@mkrauser
[Serializer] fix denormalization of basic property-types in XML and CSV
245770c 
symfony#33849
mkrauser added a commit to mkrauser/symfony that referenced this issue Nov 12, 2019
@mkrauser
[Serializer] fix denormalization of basic property-types in XML and CSV
c52f555 
symfony#33849
mkrauser added a commit to mkrauser/symfony that referenced this issue Nov 12, 2019
@mkrauser
[Serializer] fix denormalization of basic property-types in XML and CSV
7a93b05 
symfony#33849
@jewome62 jewome62 mentioned this issue Dec 9, 2019
Closed
mkrauser added a commit to mkrauser/symfony that referenced this issue Jan 22, 2020
@mkrauser
[Serializer] fix denormalization of basic property-types in XML and CSV
0cc66a8 
symfony#33849
mkrauser added a commit to mkrauser/symfony that referenced this issue Jan 22, 2020
@mkrauser
[Serializer] fix denormalization of basic property-types in XML and CSV
bef9507 
symfony#33849
mkrauser added a commit to mkrauser/symfony that referenced this issue Jan 22, 2020
@mkrauser
[Serializer] fix denormalization of basic property-types in XML and CSV
7e4fcc7 
symfony#33849
@fabpot fabpot closed this as completed Sep 2, 2020
fabpot added a commit that referenced this issue Sep 2, 2020
@fabpot
feature #33850 [Serializer] fix denormalization of basic property-typ…
4753e4d 
…es in XML and CSV (mkrauser)

This PR was submitted for the 3.4 branch but it was squashed and merged into the 5.2-dev branch instead.

Discussion
----------

[Serializer] fix denormalization of basic property-types in XML and CSV

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #33849
| License       | MIT
| Doc PR        |

Like I explained in the Issue, the serializer cannot de-serialize non-string basic properties (int, float, bool). This PR add's some logic to cast to the expected types.

Similar logic is already present in the [XmlUtils](https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Config/Util/XmlUtils.php#L215)-Class of the Config-Component

Commits
-------

3824daf [Serializer] fix denormalization of basic property-types in XML and CSV
@ugo-fl
Copy link

ugo-fl commented Apr 22, 2021

I still get that issue in the case of a custom normalizer (implements ContextAwareDenormalizerInterface in my specific case).

My denormalize function checks if $data corresponds to an existing entity in the database, and calls $this->serializer->denormalize($data, $class) otherwise. In the end, I had to manually cast every attributes to float.

@mkrauser mkrauser mentioned this issue Jan 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Serializer Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Serializer] fix denormalization of basic property-types in XML and CSV mkrauser/symfony
6 participants
@fabpot @javiereguiluz @mkrauser @ugo-fl @warslett @carsonbot