Skip to content

PasswordValidator #37093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seb-jean opened this issue Jun 4, 2020 · 4 comments
Closed

PasswordValidator #37093

seb-jean opened this issue Jun 4, 2020 · 4 comments

Comments

@seb-jean
Copy link
Contributor

seb-jean commented Jun 4, 2020

Hi,

It would be good to add a new Validator: PasswordValidator

It could check if the password is easy to guess (at least an upper case, lower case, a letter, a number and a special character for example), if the password has not been compromised and perhaps further checks.

Thank you :)

@fabpot
Copy link
Member

fabpot commented Jun 4, 2020

We already have NotCompromisedPassword.
For the other checks like having an upper case or lower case, that's a bad practice, so I would not it in core.

@fabpot fabpot closed this as completed Jun 4, 2020
@wouterj
Copy link
Member

wouterj commented Jun 4, 2020

@fabpot as it's also mentioned as an item in #30914, would you be against core support for a constraint implementing e.g. https://github.com/bjeavons/zxcvbn-php (if it's installed)? (I don't have a strong opinion, but if the core team is, we should remove that item from the #30914 list as well)

@fabpot
Copy link
Member

fabpot commented Jun 4, 2020

@wouterj I'm totally fine with supporting any algo/libs that make a sensible evaluation of the password strength.

@curry684
Copy link
Contributor

The core level support I suggested at #30914 was indeed intended to be part of the "User" convenience layer, providing a generic interface for people to implement their own checker, or easily plug in a library like zxcvbn.

If people want to implement something bad like upper/lower counting it's their own choice, we should just provide the extension point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants