-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Polyfill new phpunit 9.1 assertions #37320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@nicolas-grekas I'm up for it ✋ |
Nice thanks, can't wait! (but no hurry either :) ) |
You're welcome :) I'll get started on this and hopefully will have an update by the weekend 🤞🏼 |
@phpfour I started working on this topic a couple of weeks ago. If this commit is helpful for you, feel free to copy over as much as you like. 😃 derrabus@a05d504 |
hi @derrabus, thanks for your reference...that's quite a large commit you have...I am thinking whether it would be beneficial if I contribute to your repository to get it completed rather than doing on my own? WDYT? |
You can fetch Derrabus' fork and then cherry-pick the commit into your branch and work from that:
Or you can download the raw diff of that commit and apply it locally:
|
The commit is rather large because I've partly migrated the Symfony test suite to the polyfilled methods already. I don't think that this is necessary just yet. The interesting part is in |
I confirm migrating the test suite is not desired unless some methods are deprecated. This will save merge conflicts. |
Thanks guys for the direction, hoping to back soon with some update. |
@phpfour Is there anything I can do to support you? |
I've just pushed the commit and created the PR, sorry this has been sitting idle for a few days 😔 @nicolas-grekas @derrabus would request your review 🙏 |
This PR was merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] Polyfill new phpunit 9.1 assertions | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #37320 | License | MIT | Doc PR | - Backport of #37567, follows the discussion on #37960. Commits ------- d945b88 [PhpUnitBridge] Polyfill new phpunit 9.1 assertions
We should polyfill the new assertions added to phpunit 9.1 in our bridge, so that they can be used on lower versions of php:
https://github.com/sebastianbergmann/phpunit/blob/9.1.5/ChangeLog-9.1.md#910---2020-04-03
See links in #32922 for inspiration.
See also https://github.com/sebastianbergmann/phpunit/pull/4210/files
Help wanted!
The text was updated successfully, but these errors were encountered: