[Mailer] Too strict syntax validation for In-Reply-To and References headers
#37361
Labels
Comments
|
Hey, thanks for your report! |
|
@carsonbot Yes, still relevant. No workaround. |
|
Hey, thanks for your report! |
|
Friendly reminder that this issue exists. If I don't hear anything I'll close this. |
|
@fabpot what do you think about this ? |
|
Relaxing this would work for me. Please send a PR. |
fabpot
added a commit
that referenced
this issue
Dec 21, 2021
…uer) This PR was submitted for the 6.1 branch but it was squashed and merged into the 4.4 branch instead. Discussion ---------- [Mime] Relaxing in-reply-to header validation | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | ? | Deprecations? | no | Tickets | Fix #37361 | License | MIT | Doc PR | not necessary @nicolas-grekas 1. Is it OK to just use `UnstructuredHeader`? 2. Some tests at `IdentificationHeaderTest` are irrelevant now (but still pass) - should I remove them? And create some new test cases in `UnstructuredHeaderTest`? Or rely on every aspect being tested with other headers there, and don't add anything? Commits ------- 04ddc12 [Mime] Relaxing in-reply-to header validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Symfony version(s) affected: 4.4.10, but also present in
masterDescription
In-Reply-ToandReferencesheaders are validated as ID-Headers: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Mime/Header/Headers.php#L37...which leads to validating them as
Address: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Mime/Header/IdentificationHeader.php#L86Yes, this is exactly what RFC 2822 is saying.
However, I'm suggesting to loosen the validation.
Why? When replying to an email, the original email's
Message-IDgoes intoIn-Reply-ToorReferences. This means: If the value doesn't adhere to themsg-idspec, I can't do anything about it! The only choice I'm having is to include it as-is, or omit the header entirely. And IMO including it is the by far better choice, since it gives the recipient's MUA the possibility to correctly append it to an existing thread.The text was updated successfully, but these errors were encountered: