Skip to content

[BrowserKit] HttpBrowser ignores GET-request body #37609

Closed
@Jeroeny

Description

@Jeroeny

Symfony version(s) affected: >=4.3

Description
When using the BrowserKit to do functional tests, I've been trying to use the HttpBrowser to perform requests. Our API uses the request body to send data as JSON. The KernelBrowser doesn't seem to mind this and passes on the request to the kernel without modification. However, the HttpBrowser 'extracts' the body and does an early-return when the method is GET. This doesn't seem to comply with the RFC. And makes the use for HttpBrowser not possible for us.

How to reproduce
This is where it's filtered out: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/BrowserKit/HttpBrowser.php#L64

Possible Solution
Remove GET from the in_array check to allow bodies for GET-requests.

If that's agreed upon I'd gladly make a PR.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions