[Routing] Router ignores inline requirements of important param

**Symfony version(s) affected**: 4.4 5.2?

**Description**
As I mentioned here https://github.com/symfony/symfony/issues/40701#issuecomment-816061405. The problem not only in UrlGenerator. Router does not check important (I mean started with `!`) params inline requirements at all. I decided to open separate issue, because it could be more dangerous and it can be fixed separately. 

**How to reproduce**
Create route with important param, and set some inline requirements like:
`    #[Route('/foo/{!id<\d+>}')]
`
Open `/foo/bar` url and yes route matches the requirement

**Reason**
https://github.com/symfony/symfony/blob/1d8ad1d2ceb709ce295a61b88739c4fc70e0780d/src/Symfony/Component/Routing/RouteCompiler.php#L125-L128
$varName does not start with `!`
https://github.com/symfony/symfony/blob/1d8ad1d2ceb709ce295a61b88739c4fc70e0780d/src/Symfony/Component/Routing/RouteCompiler.php#L162
However Route requirement key starts with `!`, and param requirement set do default regex like `[^/]++`

**Possible Solution**
https://github.com/symfony/symfony/blob/1d8ad1d2ceb709ce295a61b88739c4fc70e0780d/src/Symfony/Component/Routing/Route.php#L536-L552
Do not include `!` in requirement key.
However it does not fix defaults for UrlGenerator described here #40701 



	preg_match_all('#\{(!)?(\w+)\}#', $pattern, $matches, \PREG_OFFSET_CAPTURE \| \PREG_SET_ORDER);
	foreach ($matches as $match) {
	$important = $match[1][1] >= 0;
	$varName = $match[2][0];

	private function extractInlineDefaultsAndRequirements(string $pattern): string
	{
	if (false === strpbrk($pattern, '?<')) {
	return $pattern;
	}

	return preg_replace_callback('#\{(!?\w++)(<.?>)?(\?[^\}]+)?\}#', function ($m) {
	if (isset($m[3][0])) {
	$this->setDefault($m[1], '?' !== $m[3] ? substr($m[3], 1) : null);
	}
	if (isset($m[2][0])) {
	$this->setRequirement($m[1], substr($m[2], 1, -1));
	}

	return '{'.$m[1].'}';
	}, $pattern);
	}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[Routing] Router ignores inline requirements of important param #40749

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Uh oh!

[Routing] Router ignores inline requirements of important param #40749

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions