Skip to content

[Messenger] [DX] Redis default configuration lead to fill server #42122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
magnetik opened this issue Jul 15, 2021 · 5 comments · Fixed by #42163
Closed

[Messenger] [DX] Redis default configuration lead to fill server #42122

magnetik opened this issue Jul 15, 2021 · 5 comments · Fixed by #42163
Labels
DX DX = Developer eXperience (anything that improves the experience of using Symfony) Messenger

Comments

@magnetik
Copy link
Contributor

Description
Currently, the default redis configuration with lead to fill the redis server because messages are never deleted.

The documentation has a little warning :
image
(This warning should maybe red as it will lead to break production at some point)

It seems to me that the default configuration can be improved so acked message are deleted by default.

WDYT ?
@carsonbot carsonbot added DX DX = Developer eXperience (anything that improves the experience of using Symfony) Messenger labels Jul 15, 2021
@chalasr
Copy link
Member

chalasr commented Jul 15, 2021

I agree here, with messenger this option makes sense as a default.
/cc @Seldaek @alexander-schranz

@alexander-schranz
Copy link
Contributor

@chalasr was thinking the same in the past that for Symfony 6 it will make sense to make delete_after_ack=true as default value as the other transports like doctrine behave the same way. So the once which use redis then as real stream can set it then to false with delete_after_ack=false. But think the most people use redis just as an alternative to doctrine transport and don't need to stream feature with groups and multiple receivers where the messages need to be stay.

@Seldaek
Copy link
Member

Seldaek commented Jul 15, 2021 •
edited
Loading

I fully agree, the default is currently harmful and surprising, if you don't read the fine print you'll shoot yourself in the foot.

@chalasr chalasr mentioned this issue Jul 16, 2021
Merged
@chalasr
Copy link
Member

chalasr commented Jul 17, 2021

See #42163

@magnetik
Copy link
Contributor Author

Awesome ! Ton of thanks 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DX DX = Developer eXperience (anything that improves the experience of using Symfony) Messenger
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Messenger] [Redis] Prepare turning delete_after_ack to true in 6.0 chalasr/symfony
5 participants
@Seldaek @magnetik @alexander-schranz @chalasr @carsonbot