Skip to content

audit-trail workflow configuration in xml not working #43194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
temp opened this issue Sep 27, 2021 · 4 comments · Fixed by #43206
Closed

audit-trail workflow configuration in xml not working #43194

temp opened this issue Sep 27, 2021 · 4 comments · Fixed by #43206
Labels
Bug Good first issue Ideal for your first contribution! (some Symfony experience may be required) Help wanted Issues and PRs which are looking for volunteers to complete them. Status: Needs Review Workflow

Comments

@temp
Copy link

temp commented Sep 27, 2021 •
edited
Loading

Symfony version(s) affected: 5.3.7

Description
Using the xml-example from https://symfony.com/doc/current/workflow.html#creating-a-workflow throws errors.

 Unable to parse file "/app/config/packages/workflow.xml": [ERROR 1871] Element '{http://symfony.com/schema/dic/symfony}audit-trail': This element is not expected. Expected is one of ( {http://symfony.com/schema/dic/symfony}initial-marking, {http:
  //symfony.com/schema/dic/symfony}marking-store, {http://symfony.com/schema/dic/symfony}support, {http://symfony.com/schema/dic/symfony}event-to-dispatch, {http://symfony.com/schema/dic/symfony}place, {http://symfony.com/schema/dic/symfony}transit
  ion, {http://symfony.com/schema/dic/symfony}metadata ). (in /app/ - line 11, column 0) in /app/config/packages/workflow.xml (which is being imported from "/app/src/Kernel.php").

How to reproduce
Use the xml-example workflow.xml from https://symfony.com/doc/current/workflow.html#creating-a-workflow

Possible Solution

Additional context
Maybe the audit-trail config is simply missing from the xsd?
@temp temp added the Bug label Sep 27, 2021
@stof
Copy link
Member

stof commented Sep 27, 2021

@temp it is indeed missing in the XSD. Do you want to submit a PR adding it ?

@stof stof added Good first issue Ideal for your first contribution! (some Symfony experience may be required) Help wanted Issues and PRs which are looking for volunteers to complete them. Workflow labels Sep 27, 2021
@temp
Copy link
Author

temp commented Sep 27, 2021

@stof Yes, can do!

@himanshu007-creator
Copy link

Hi, I would like to work on this issue. Please guide me further on what needs to be done ^_^

@temp temp mentioned this issue Sep 28, 2021
Merged
@temp
Copy link
Author

temp commented Sep 28, 2021

Hi, I would like to work on this issue. Please guide me further on what needs to be done ^_^

Oh, sorry, did see your comment only after I submitted the PR.

fabpot added a commit that referenced this issue Sep 28, 2021
@fabpot
bug #43206 [Workflow] Add missing audit-trail settings in framework w…
de2ff10 
…orkflow con… (Stephan Wentz)

This PR was submitted for the 5.4 branch but it was merged into the 5.3 branch instead.

Discussion
----------

[Workflow] Add missing audit-trail settings in framework workflow con…

audit-trail config was missing in xsd. Example from symfony.com did not work as expected due to this.

| Q             | A
| ------------- | ---
| Branch?       | 5.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #43194
| License       | MIT
| Doc PR        |  N/A

Commit adds audit-trail in xsd

Commits
-------

6d2b71e [Workflow] Add missing audit-trail settings in framework workflow config xsd
@fabpot fabpot closed this as completed Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Good first issue Ideal for your first contribution! (some Symfony experience may be required) Help wanted Issues and PRs which are looking for volunteers to complete them. Status: Needs Review Workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Workflow] Add missing audit-trail settings in framework workflow con… temp/symfony
5 participants
@fabpot @temp @stof @carsonbot @himanshu007-creator