Skip to content

A unit fails on php 5.4 #4718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabpot opened this issue Jul 3, 2012 · 5 comments
Closed

A unit fails on php 5.4 #4718

fabpot opened this issue Jul 3, 2012 · 5 comments
Labels
Intl

Comments

@fabpot
Copy link
Member

fabpot commented Jul 3, 2012

  1. Symfony\Component\Locale\Tests\Stub\StubNumberFormatterTest::testParseTypeInt64IntlWith32BitIntegerInPhp32Bit
    Failed asserting that -2147483648 is of type "float".

/home/vagrant/builds/symfony/symfony/src/Symfony/Component/Locale/Tests/Stub/StubNumberFormatterTest.php:934

@eriksencosta: Can you have a look at it?
@ghost
Copy link

ghost commented Jul 3, 2012

I'm already looking it. I'm compiling some different PHP versions (5.3.3, 5.3.14 and 5.4.4) with different ICU versions (4.2 to 4.6) to know if the error is from PHP or intl.

@ghost
Copy link

ghost commented Jul 3, 2012

It fails also on 5.3.14.

fabpot added a commit that referenced this issue Jul 4, 2012
@fabpot
[Locale] skipped a test until #4718 is fixed (refs #4718)
e71149b
@fabpot
Copy link
Member Author

fabpot commented Jul 4, 2012

I've commented the test for now to avoid having all builds fail.

@ghost
Copy link

ghost commented Jul 4, 2012

Ok. Now I have all the necessary stuff on a 32bit VM. I'll probably make a PR later today.

@ghost
Copy link

ghost commented Jul 5, 2012

The PHP guys fixed a bug that I reported some time ago. It's because this fix that our test fail :)

This was referenced Jul 5, 2012
Closed
Merged
@fabpot fabpot closed this as completed in 28f002d Jul 9, 2012
fabpot added a commit that referenced this issue Jul 9, 2012
@fabpot
merged branch eriksencosta/issue-4718 (PR #4794)
fd1d5e8 
Commits
-------

28f002d [Locale] fixed bug on the parsing of TYPE_INT64 integers in 32 bit and 64 bit environments, caused by PHP bug fix :) (closes #4718)

Discussion
----------

[Locale] fixed bug on the parsing of TYPE_INT64 integers in 32 bit and 64 bit environments, caused by PHP bug fix

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #4718
License of the code: MIT

[![Build Status](https://secure.travis-ci.org/eriksencosta/symfony.png?branch=issue-4718)](http://travis-ci.org/eriksencosta/symfony)

Tests pass on PHP 5.3.3, 5.3.14 and 5.4.4 with ICU 4.2, 4.4 and 4.6 on 32 and 64 bit environments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Intl
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fabpot