Thank you for this suggestion.
There has not been a lot of activity here for a while. Would you still like to see this feature?

Still would be useful, don't stale.

Just to update on this. I started to implement something to support predis 1 and 2, but it became challenging to test.

The project depends on pedis 1, and apart from making it require 1 || 2, it would require some dancing on composer install to make it install the right version for every particular test.

After some time it was hard to find the motivation to continue, as I had a working workaround for my use case.

But yeah, ideally this should happen, because predis 1 is no longer maintained AFAIK.

Perhaps aiming to support only predis 2 once Symfony 7 releases would simplify things here.

Thank you for this suggestion.
There has not been a lot of activity here for a while. Would you still like to see this feature?

Thank you for this suggestion.
There has not been a lot of activity here for a while. Would you still like to see this feature?

I definitely would 😅

PR welcome of course. It'd be great to figure out a way to make the adapter work with both versions of Predis.

PR welcome of course. It'd be great to figure out a way to make the adapter work with both versions of Predis.

Is there any other scenario where Symfony supports multiple major versions of the same dependency, that I could take a look at? As I mentioned a few months ago, the main challenge is to make sure tests are run with the appropriate predis version.

Also, it seems predis v3.0.0 is around the corner, just to make things more interesting 😅

predis 1 seems to still be the most installed version https://packagist.org/packages/predis/predis/stats#major/all, although v2 is slowly catching up.

We run tests with the lastet and with the lowest supported versions of deps automatically so there is nothing to do to have them installed. Then, test cases would need to be written in a way that can selectively run with v1 or v2 depending on what is installed. (let's see v3 as another future step)

Hello @nicolas-grekas,

to support v1 and v2 following code adjustments can be made:

use Predis\Connection\Aggregate\ReplicationInterface as ReplicationInterfaceV1;
use Predis\Connection\Replication\ReplicationInterface as ReplicationInterfaceV2;

[...]

        if ($host instanceof \Predis\Client) {
            $connection = $host->getConnection();

            if ($connection instanceof ReplicationInterfaceV1) {
                $hosts = [$host->getClientFor('master')];
            } elseif ($connection instanceof ReplicationInterfaceV2) {
                $connection->switchToMaster();

                $hosts = [$host];
            }
        }

I've tried to fix this and write some tests.
Can someone look over the connection strings?

Thank you!

#59751