Skip to content

Missing translations for Chinese (zh_CN) #51933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
carsonbot opened this issue Oct 10, 2023 · 2 comments
Closed

Missing translations for Chinese (zh_CN) #51933

carsonbot opened this issue Oct 10, 2023 · 2 comments
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Help wanted Issues and PRs which are looking for volunteers to complete them. Missing translations

Comments

@carsonbot
Copy link

carsonbot commented Oct 10, 2023 •
edited
Loading

Hello,

There are some missing Chinese (zh_CN) translations and we are looking for a native speaker to help us out.

Here is a short example of what you need to do. There are 4 rules:

  1. You must be a Chinese (zh_CN) native speaker
  2. You must look at the existing translations and follow the same "style" or "tone"
  3. You must make your PR to branch 5.4
  4. You must use the correct indentation (number of spaces)

These are the files that should be updated:

Note

If you want to work on this issue, add a comment to assign it to yourself and let others know that this is already taken.
@carsonbot carsonbot added Good first issue Ideal for your first contribution! (some Symfony experience may be required) Help wanted Issues and PRs which are looking for volunteers to complete them. Missing translations labels Oct 10, 2023
@Guxinpei
Copy link
Contributor

Hello,

I am a native Chinese (zh_CN) speaker and would like to help with the missing translations. I have reviewed the existing translations and understand the style and tone required. I am familiar with the indentation guidelines and will make my PR to branch 5.4. Please assign this issue to me. Thank you!

Best regards,
Roog

@fabpot
Copy link
Member

fabpot commented Oct 29, 2023

@Guxinpei Please go ahead, thank you.

@Guxinpei Guxinpei mentioned this issue Oct 29, 2023
Merged
nicolas-grekas added a commit that referenced this issue Oct 29, 2023
@nicolas-grekas
minor #52359 [Validator] Added Chinese(zh_CN) translations (Guxinpei)
b922c37 
This PR was merged into the 5.4 branch.

Discussion
----------

[Validator] Added Chinese(zh_CN) translations

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #51933 <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->
| License       | MIT

[Validator] Added Chinese(zh_CN) translations

Commits
-------

b2cd1a5 [Validator] Added Chinese(zh_CN) translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Help wanted Issues and PRs which are looking for volunteers to complete them. Missing translations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fabpot @nicolas-grekas @carsonbot @Guxinpei