Skip to content

How to drop Mailer/Sendinblue and Notifier/Sendinblue #52097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
OskarStark opened this issue Oct 17, 2023 · 3 comments
Closed

How to drop Mailer/Sendinblue and Notifier/Sendinblue #52097

OskarStark opened this issue Oct 17, 2023 · 3 comments
Labels
Help wanted Issues and PRs which are looking for volunteers to complete them. Mailer Notifier

Comments

@OskarStark
Copy link
Contributor

OskarStark commented Oct 17, 2023 •
edited
Loading

Sendinblue was rebranded to Brevo and we already have bridge for them.

I would simply drop those bridges in 7.0 and abandon the packages on 6.4 with a replacement to the brevo bridge. It is a 1:1 drop-in replacement

WDYT @stof @fabpot @nicolas-grekas
@OskarStark OskarStark added Help wanted Issues and PRs which are looking for volunteers to complete them. Mailer Notifier labels Oct 17, 2023
@OskarStark
Copy link
Contributor Author

I talked to Nicolas via Slack, and we do it the proposed way 👍

@stof
Copy link
Member

stof commented Oct 17, 2023

The sendinblue bridges already trigger deprecations in 6.4 when the factories are used to create a transport. So marking the packages as abandoned on Packagist after the 6.4 stable release is the way to go, and those packages should not exist in 7.0

@OskarStark
Copy link
Contributor Author

Already fixed in

@vicla31 vicla31 mentioned this issue Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help wanted Issues and PRs which are looking for volunteers to complete them. Mailer Notifier
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stof @OskarStark