-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Help Wanted: fix failure on WebProfilerBundle 5.4 loaded with higest deps #52210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
1) Symfony\Bundle\WebProfilerBundle\Tests\Controller\ProfilerControllerTest::testPanelActionWithLatestToken
UnexpectedValueException: The profiler template "@WebProfiler/Collector/command.html.twig" for data collector "command" does not exist. Two choices:
|
The change should be done in 6.4 ideally /cc @HeahDude |
It seems I see tow options:
I would go for the second solution. |
Patching 5.4 to account for 6.4 would be wrong, so solution 2 would be the way. Ideally, I'd prefer FWB to not know about WPB. Is there no solution that doesn't involve adding any conflict line? |
See #52218. |
The conflict line was already there because I guess the problem was always there, adding collectors in FWB while adding templates in WebProfilerBundle. |
…6.4 (HeahDude) This PR was merged into the 6.4 branch. Discussion ---------- [FrameworkBundle] Add conflict with `WebProfilerBundle` < 6.4 | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | #52210 | License | MIT Commits ------- 6f8c912 [FrameworkBundle] Add conflict with `WebProfilerBundle` < 6.4
So we can close here I guess. |
…tered (smnandre) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [FrameworkBundle] Fix CommandDataCollector is always registered | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #52210 | License | MIT Another attempt at fixing #52210, allowing to revert #52218 and leave the conflict constraints untouched CommandDataCollector was always registered, and not always removed from the container when not needed/invalid. Commits ------- 6e2c2ec [FrameworkBundle] Fix CommandDataCollector is always registered
Uh oh!
There was an error while loading. Please reload this page.
On 5.4, we have a failure to fix:
https://github.com/symfony/symfony/actions/runs/6590102626/job/17912208613#step:7:393
I can reproduce it by going into the
src/Symfony/Bundle/WebProfilerBundle
folder on branch 5.4, then running composer up andSYMFONY_DEPRECATIONS_HELPER=weak ../../../../phpunit --filter testPanelActionWithLatestToken$
Help welcome to figure out the issue and fix it!
The text was updated successfully, but these errors were encountered: