Skip to content

[Messenger] Wait for stopped workers #54037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ro0NL opened this issue Feb 22, 2024 · 3 comments
Closed

[Messenger] Wait for stopped workers #54037

ro0NL opened this issue Feb 22, 2024 · 3 comments

Comments

@ro0NL
Copy link
Contributor

ro0NL commented Feb 22, 2024

Description

I believe messenger:stop-workers should be waiting by default (or optin --wait) for workers actually to be stopped (while true check if redis flag is cleared)

Currently a pre-deploy container can be finished before workers are stopped, causing the deploy to trigger while a worker job is processing still.

It's not ideal :)

Example

No response

@ro0NL
Copy link
Contributor Author

ro0NL commented Sep 3, 2024

note to self; sometimes we also want to stop workers but keep the process alive, e.g. when updating the queue server. The workers should be resumed manually after upgrading.

@n0-m4d
Copy link

n0-m4d commented Feb 8, 2025

why closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants