Skip to content

Backport "[FrameworkBundle] Fix warming up routes" for 6.4.9 #57727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rejhgadellaabsl opened this issue Jul 15, 2024 · 4 comments
Closed

Backport "[FrameworkBundle] Fix warming up routes" for 6.4.9 #57727

rejhgadellaabsl opened this issue Jul 15, 2024 · 4 comments
Labels
Bug FrameworkBundle Status: Needs Review Status: Waiting feedback

Comments

@rejhgadellaabsl
Copy link

rejhgadellaabsl commented Jul 15, 2024 •
edited
Loading

Symfony version(s) affected

6.4.9

Description

Since 6.4.9[1], the drupal/simplesamlphp_auth module will sometimes throw an error when attempting to log in the user:

The router "Symfony\Component\Routing\Router" cannot be warmed up because it does not implement "Symfony\Component\HttpKernel\CacheWarmer\WarmableInterface".

[1] The bug might have been introduced in 6.4.8 it never occured because there was another error (#57316)

How to reproduce

Using Drupal 10.2.7 or higher with the simplesaml_auth 4.0.0 module, try to log in.

Possible Solution

It looks like this was fixed in 7.1.2 (see #57554 and 35d085dc18b494d20b75728ecb222543e760c515), but would appreciate if this could be backported for 6.4.x.

Additional Context

Also see the related simplesamlphp_auth bug
@rejhgadellaabsl rejhgadellaabsl changed the title Backport '' for 6.4.9 Backport "[FrameworkBundle] Fix warming up routes" for 6.4.9 Jul 15, 2024
@xabbuh
Copy link
Member

xabbuh commented Jul 17, 2024

Can you try to debug which commit broke the previous behaviour (or provide a small example application that allows to reproduce it)?

@rejhgadellaabsl
Copy link
Author

I'm afraid that putting together a simple example application isn't very straightforward for me. We run into the bug in a Drupal site that uses the simplesamlphp_auth module. I'm not sure where I would need to begin to find where / when this bug started occurring.

In the related simplesamlphp_auth bug ticket, someone provided a back-ported patch for 6.4.9, based on #57554. AFAICT, that fixes the issue for us, but others report that they're still seeing the issue. That's pretty much all I know...

@xabbuh
Copy link
Member

xabbuh commented Jul 24, 2024

Looking at the error message and the stack trace I am not sure that #57554 would actually help here. The referenced bug seems to fail over the router being an instance of the Router class from the Routing component (which indeed does not implement the WarmableInterface) while the class patched in #57554 is the Router class from the FrameworkBundle.

Is it expected in Drupal that the router service uses the class from the component and not the one from the component?

@xabbuh
Copy link
Member

xabbuh commented Aug 2, 2024

Let's close here for now as said before I don't see how #57554 would help with that concrete problem. We can consider to reopen once we have more information.

@xabbuh xabbuh closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Needs Review Status: Waiting feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xabbuh @carsonbot @rejhgadellaabsl