[FrameworkBundle] Fix warming up routes #57554
Conversation
6a13d21 to
c95bd32
Compare
c95bd32 to
cc918e9
Compare
| @@ -84,14 +84,12 @@ public function getRouteCollection(): RouteCollection | |||
|
|
|||
| public function warmUp(string $cacheDir, ?string $buildDir = null): array | |||
| { | |||
| if (!$buildDir) { | |||
| return []; | |||
| if (null === $currentDir = $this->getOption('cache_dir')) { | |||
There was a problem hiding this comment.
Isn't the CacheWarmer not registered when the caching is disabled for the router ?
And with this change, the Router cache is generated once at build-time and once again if you run cache:warmup, right ?
If you run cache:warmup right after your deploy (thus, on a read-only buildDir), this will either fail or you regenerate the router cache in the cache_dir, which won't be used at all.
There was a problem hiding this comment.
no it's not disabled if you set the router.cache_dir to null (which is the only way since the deprecation of the config option)
There was a problem hiding this comment.
If you run cache:warmup right after your deploy (thus, on a read-only buildDir), this will either fail or you regenerate the router cache in the cache_dir, which won't be used at all.
then, $buildDir will be null so that RouterCacheWarmer won't call this warmup method
There was a problem hiding this comment.
then, $buildDir will be null so that RouterCacheWarmer won't call this warmup method
Ah right, I got caught by the double warming layer of the Router... 👍
Follows #52962 and builds on the semantics of #57553.