-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Webhooks] Add a github provider #58471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Sounds good to me. |
Can you give me some guidance on how to set this up as a bundle? I imagine in the GithubWebhookBundle.php there's a service that has a tag on it, and then the application that uses the bundle adds a RemoteEventConsumer? |
To me, parsing GitHub webhook payloads into a RemoteEvent is not something that belongs in the core of Symfony. Our parsers in core bridges are all about parsing a subset of the webhook payload into a shared abstraction of mailer or notifier webhooks. GitHub webhooks don't make sense in those abstraction. Writing a dedicated GitHub-specific webhook request parser exposing the full GitHub payload to write GitHub-specific webhook consumers is something that should be provided by a bundle out of core IMO (which would also allow it to make releases much more often, to react to changes in the GitHub webhooks to add new fields for instance). |
Symfony's @carsonbot uses github webhooks so if git webhook abstraction would be integrated in core, it could be direct user of this |
if it is in a bundle, it could also use the bundle. The fact that one of our tool has such need is not a sufficient argument to bring it in core. |
Perhaps it would be a good fit for https://github.com/KnpLabs/php-github-api Just brainstorming: The bundle could provide a command line tool that registers the webhook on github. bin/console github:register https://my-application --event=issue.new --event=pull.request --event=release.new (I'm making up these event names). |
Thank you for this suggestion. |
Friendly reminder that this issue exists. If I don't hear anything I'll close this. |
Hey, I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen! |
Uh oh!
There was an error while loading. Please reload this page.
Description
The providers on https://symfony.com/doc/current/webhook.html are for email and notifiers (like SMS). Since every developer using Symfony has a github account and many use github for their applications, a native github provider would be useful.
Example
The text was updated successfully, but these errors were encountered: