[Form] Couldn't set invalid_message for DateType #5880

scourgen · 2012-10-31T16:21:54Z

in my case, I have a form,that has a date column,and I want validate this date column like this: If user did something wrong,I would like to tell them what happen(forgot or typed/select the wrong date)

I assume what could happen is like:

If user selected (nothing)-(4)-(1),the error message will be "year is missing",
If user selected (1980)-(nothing)-(1),the error message will be "month is missing"
If user selected (1980)-(nothing)-(nothing),the error message will be "month is missing" and "day is missing"

But I found out that I could't set the invalid_message for each input(year/month/day)

the truth is I can't define the invalid_message separately. When I typed wrong, I always get the error "This value is not valid."

so I spent some time on the code, finally I got this:

Symfony/Component/Form/Extension/Core/Type/DateType.php

            if ('choice' === $options['widget']) {
                // Only pass a subset of the options to children
                $yearOptions['choices'] = $this->formatTimestamps($formatter, '/y+/', $this->listYears($options['years']));
                $yearOptions['empty_value'] = $options['empty_value']['year'];
                $monthOptions['choices'] = $this->formatTimestamps($formatter, '/M+/', $this->listMonths($options['months']));
                $monthOptions['empty_value'] = $options['empty_value']['month'];
                $dayOptions['choices'] = $this->formatTimestamps($formatter, '/d+/', $this->listDays($options['days']));
                $dayOptions['empty_value'] = $options['empty_value']['day'];
            }

looks like It doesn't pass the invalid_message to field year/month/day . so when the field gets wrong,It will always shows the default message . I can't even change it !

I made a simple fix like following code:

diff --git a/src/Symfony/Component/Form/Extension/Core/Type/DateType.php b/src/Symfony/Component/Form/Extension/Core/Type/DateType.php
index cb956e7..32b9399 100644
--- a/src/Symfony/Component/Form/Extension/Core/Type/DateType.php
+++ b/src/Symfony/Component/Form/Extension/Core/Type/DateType.php
@@ -84,10 +84,13 @@ class DateType extends AbstractType
                 // Only pass a subset of the options to children
                 $yearOptions['choices'] = $this->formatTimestamps($formatter, '/y+/', $this->listYears($options['years']));
                 $yearOptions['empty_value'] = $options['empty_value']['year'];
+                $yearOptions['invalid_message'] = $options['invalid_message_year'];
                 $monthOptions['choices'] = $this->formatTimestamps($formatter, '/M+/', $this->listMonths($options['months']));
                 $monthOptions['empty_value'] = $options['empty_value']['month'];
+                $monthOptions['invalid_message'] = $options['invalid_message_month'];
                 $dayOptions['choices'] = $this->formatTimestamps($formatter, '/d+/', $this->listDays($options['days']));
                 $dayOptions['empty_value'] = $options['empty_value']['day'];
+                $dayOptions['invalid_message'] = $options['invalid_message_day'];
             }

             // Append generic carry-along options
@@ -214,6 +217,9 @@ class DateType extends AbstractType
             // this option.
             'data_class'     => null,
             'compound'       => $compound,
+            'invalid_message_day'       => 'This value(day) is not valid.',
+            'invalid_message_month'       => 'This value(month) is not valid.',
+            'invalid_message_year'       => 'This value(year) is not valid.',
         ));

         $resolver->setNormalizers(array(

so I can define them separately like following:

        $form = $this->createFormBuilder()
        ->add('birthdate','birthday',array(
            'empty_value'=>array(
                    'year'=>'year',
                    'month'=>'month',
                    'day'=>'day'
                ),
            'widget'=>'choice',
            'invalid_message'=>'invalid_message for birthday',
                'invalid_message_year'=>'invalid_message for birthday:year',
                'invalid_message_month'=>'invalid_message for birthday:month',
                'invalid_message_day'=>'invalid_message for birthday:day',
        ))->getForm();

scourgen · 2012-10-31T16:51:23Z

btw, by default, If I select (nothing)-(1)-(1) at following form,I will get "This value is not valid." twice

        $form = $this->createFormBuilder()
        ->add('birthdate','birthday',array(
            'empty_value'=>array(
                    'year'=>'year',
                    'month'=>'month',
                    'day'=>'day'
                ),
            'widget'=>'choice'
        ))->getForm();

scourgen · 2012-10-31T17:05:44Z

or we can disable the error_bubbling and assume they are a whole?

rvanlaak · 2015-05-05T08:10:08Z

I'd like to edit the invalid_message on a related entity of an object, which is validated using @Assert\Valid(). But as the Valid constraint has no message, it seems like it can't be modified.

So, this does not work:

/**
* @Assert\Valid(message="Custom invalid message")
*/

And this does not work either:

$formBuilder->add('editor', 'entity', array(
    'required'      => true,
    'constraints' => new Valid(array('message' => 'Custom invalid message')),
    'invalid_message' => 'Custom invalid message',
));

awudarowicz · 2017-11-23T12:01:36Z

What about this bug? Because it's 2017 and I'm facing now this issue :)

Solution provided by @scourgen looks ok. If you don't want to add separated messages for year, month, day then add just invalid_message to all sub types:

$yearOptions['invalid_message'] = $options['invalid_message'];
$monthOptions['invalid_message'] = $options['invalid_message'];
$dayOptions['invalid_message'] = $options['invalid_message'];

because now when error occurs in one of the sub types (year|month|day) then message is always "This value is not valid." and we cannot change it.

Simperfit · 2017-11-28T06:22:04Z

@awudarowicz Do you want to provide a fix ?

…abbuh) This PR was merged into the 2.8 branch. Discussion ---------- [Form] forward the invalid_message option in date types | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #5880 | License | MIT | Doc PR | Commits ------- 5318e2e forward the invalid_message option in date types

javiereguiluz added the Bug label Feb 5, 2016

carsonbot added the Status: Needs Review label Feb 5, 2016

xabbuh mentioned this issue Sep 14, 2018

[Form] forward the invalid_message option in date types #28464

Merged

xabbuh added Status: Reviewed and removed Status: Needs Review labels Sep 14, 2018

nicolas-grekas closed this as completed Sep 20, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Form] Couldn't set invalid_message for DateType #5880

[Form] Couldn't set invalid_message for DateType #5880

scourgen commented Oct 31, 2012

scourgen commented Oct 31, 2012

scourgen commented Oct 31, 2012

rvanlaak commented May 5, 2015

awudarowicz commented Nov 23, 2017 •

edited

Loading

Simperfit commented Nov 28, 2017

[Form] Couldn't set invalid_message for DateType #5880

[Form] Couldn't set invalid_message for DateType #5880

Comments

scourgen commented Oct 31, 2012

scourgen commented Oct 31, 2012

scourgen commented Oct 31, 2012

rvanlaak commented May 5, 2015

awudarowicz commented Nov 23, 2017 • edited Loading

Simperfit commented Nov 28, 2017

awudarowicz commented Nov 23, 2017 •

edited

Loading