-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[RFC] Deprecate and remove support for semantic XML configuration #60200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
What do you mean by "it"?
I agree but I really didn't see any project using it. More over, this configuration formation is painful to use (event for end user) And Doctrine has already removed a configuration format. So there is a precedent 😃 |
This is not trivial as there is some transformations of the input before validating the configuration (example in DoctrineBundle) that requires a specific schema file. We hit this issue while trying to generate the JSON schema configuration in #59620
|
I'd like to, but I don't know where we could put it to reach the maximum number of people. |
During https://live.symfony.com/ |
I think there is 2 different cases here:
I know that some projects use XML files for the second case (the XSD provides better IDE support that for Yaml files for instance). |
Reading the issue again, I see that it proposes only the deprecation of the first case. I got confused by #60568 that deprecates everything about XML when claiming to fix this issue. |
I'm in favor of dropping everything XML-related. Json-schema & array-shapes to the rescue instead of XSD if we want to provide an alternative IMHO. |
Using XML for services and routes definition has been the dominant practice in popular bundles.
Let's focus on semantic configuration first, which is much more rarely (if ever) used. |
Sure, that's why we need to deprecate first, then remove as usual. Keeping part of the xml stuff wouldn't allow us to remove any code, making the effort worthless. On the contrary, sending a message to bundles that they should move to php config is desirable - the format exists long enough. |
I would start with this first 👍🏼
No, we well be able to drop some code!
|
Not sure what y'all mean by "first": maintaining XML loaders for 5 more years in 8.x cycle? Better not! |
héhé, just to clarify : I don't like to maintain XML support in semantic configuration. I don't really maintain routing & service configuration. That's why I wanted to remove only semantic configuration. But if we all agree to drop all XML configuration, I'm obviously okay with that! |
Description
Maintaining https://github.com/symfony/symfony/blob/7.3/src/Symfony/Bundle/FrameworkBundle/Resources/config/schema/symfony-1.0.xsd is not easy.
And I never saw a project using XML to configure the framework.
So I propose to remove this support. I know it's always heartbreaking to remove a feature, but I really think it's much better for Symfony maintainers.
More over, we now have much better format to configure the framework...
Example
No response
The text was updated successfully, but these errors were encountered: