[DependencyInjection][Routing][Serializer][Validator] Deprecate XML configuration format #60568
Conversation
2169ea4 to
c5c98cb
Compare
c5c98cb to
e7849d9
Compare
f21defc to
d725030
Compare
|
Let's wait on the discussion on the issue to know what should actually be deprecated. This PR deprecates a lot more than what was mentioned in the issue it fixes. |
| public function testInlineServicesAreNotCandidates() | ||
| { | ||
| $this->expectUserDeprecationMessage('Since symfony/dependency-injection 7.4: XML configuration format is deprecated, use YAML or PHP instead.'); |
There was a problem hiding this comment.
shouldn't we rewrite this to use another format instead?
There was a problem hiding this comment.
This test looks like it’s XML specific: #24491
| @@ -32,6 +33,8 @@ | |||
|
|
|||
| class XmlDumperTest extends TestCase | |||
There was a problem hiding this comment.
side question: do we want to keep the xml dumper?
it's used by some external tools AFAIK, so likely yes
There was a problem hiding this comment.
We also have commands loading such XML dumps, like debug:container. Not sure what we should do about that.
There was a problem hiding this comment.
FTR I gave a try on other formats: PHP dumper cannot dump a non-compiled container, and YAML dumper suffers from #60573
| public function testImportWithGlobPattern() | ||
| { | ||
| $this->expectUserDeprecationMessage('Since symfony/dependency-injection 7.4: XML configuration format is deprecated, use YAML or PHP instead.'); |
There was a problem hiding this comment.
maybe remove/spli the xml part? a legacy test case is usually planned for removal, which isn't the case for this one, right?
There was a problem hiding this comment.
I assumed we could simply remove the XML part from the test on 8.0 but after a second look it seems it would be better to replace the XML config with a PHP one in this PR.
| @@ -116,8 +116,13 @@ public function testLoadParameters() | |||
| $this->assertEquals(['foo' => 'bar', 'mixedcase' => ['MixedCaseKey' => 'value'], 'values' => [true, false, 0, 1000.3, \PHP_INT_MAX], 'bar' => 'foo', 'escape' => '@escapeme', 'foo_bar' => new Reference('foo_bar')], $container->getParameterBag()->all(), '->load() converts YAML keys to lowercase'); | |||
| } | |||
|
|
|||
| /** | |||
| * @group legacy | |||
There was a problem hiding this comment.
Addressed as well
| DependencyInjection | ||
| ------------------- | ||
|
|
||
| * Deprecate XML configuration format, use YAML or PHP instead |
There was a problem hiding this comment.
genuine question; wdyt documenting PHP before YAML?
seeing more and more config file written in PHP lately as the ecosystem and tooling evolve
(symfony core included)
There was a problem hiding this comment.
yaml is still the best way to go in combination with flex/recipes
There was a problem hiding this comment.
If we’re going to order the alternatives, is it correct for the other components’?
d725030 to
d1a9099
Compare
d1a9099 to
ded957c
Compare
From #60560 (comment)