Skip to content

[Form] Field type number, misleading option "precision" actually handles, refers to "scale" #7383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
groucho-zz opened this issue Mar 14, 2013 · 3 comments
Closed

[Form] Field type number, misleading option "precision" actually handles, refers to "scale" #7383

groucho-zz opened this issue Mar 14, 2013 · 3 comments
Labels
Enhancement Form

Comments

@groucho-zz
Copy link

It is misleading to name the option "precision" when it actually refers to the
numbers after the decimal point, which should have been "scale" as it is declared
in the Entity for doctrine.

and generally in mysql :
http://dev.mysql.com/doc/refman/5.1/en/precision-math-decimal-changes.html

M is the maximum number of digits (the precision)
D is the number of digits to the right of the decimal point (the scale)
@jfsimon
Copy link
Contributor

jfsimon commented Apr 11, 2013

Renaming this option would be a huge BC break!

@groucho-zz
Copy link
Author

@jfsimon true, but it's still clearly incorrect, and a bit misleading.

@webmozart
Copy link
Contributor

Feel welcome to open a PR that introduces a new alias "scale" for "precision". Look at https://github.com/symfony/symfony/pull/6573/files to see how option aliasing works.

@wouterj wouterj mentioned this issue Feb 17, 2015
Merged
fabpot added a commit that referenced this issue Apr 3, 2015
@fabpot
feature #13717 Deprecated precision option in favor of scale (WouterJ)
53fa5e3 
This PR was merged into the 2.7 branch.

Discussion
----------

Deprecated precision option in favor of scale

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #7383
| License       | MIT
| Doc PR        | symfony/symfony-docs#5005

Scale is the number of digits to the right of the decimal point in a number, precision isn't. See the referenced ticket for more context.

Commits
-------

2a2f7e2 Deprecated precision option in favor of scale
@fabpot fabpot closed this as completed Apr 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Form
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fabpot @jfsimon @webmozart @groucho-zz