Skip to content

XmlUtils::phpize floats integer-lists #7644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
possi opened this issue Apr 12, 2013 · 0 comments
Closed

XmlUtils::phpize floats integer-lists #7644

possi opened this issue Apr 12, 2013 · 0 comments
Labels
Config Good first issue Ideal for your first contribution! (some Symfony experience may be required)

Comments

@possi
Copy link

possi commented Apr 12, 2013

I'm trying to let my config accept:

<node attribute="1234,5678,9101,1121,3141" />

to parse the this attribute as a string. But the Symfony\Component\Config\Util\XmlUtils::phpize-Method (previously SimpleXMLElement::phpize) replaces this to float(1.2345678910111E+19).

This is caused by the preg_match-case.
@cordoval cordoval mentioned this issue Apr 12, 2013
Closed
fabpot pushed a commit that referenced this issue Apr 20, 2013
@cordoval @fabpot
[Config] #7644 add tests for passing number looking attributes as str…
d98118a 
…ings
fabpot added a commit that referenced this issue Apr 20, 2013
@fabpot
merged branch cordoval/bugfix/7644 (PR #7655)
64ac4d1 
This PR was squashed before being merged into the 2.2 branch (closes #7655).

Discussion
----------

[Config] #7644 add tests for passing number looking attributes as strings

| Q                       | A                 |
| -----------------  |:-------------:|
| Bug fix?            | yes             |
| New feature     | no               |
| BC breaks?     | no               |
| Deprecations?| no               |
| Tests pass?    | yes             |
| Fixed tickets    | #7644        |
| License            | MIT            |

Commits
-------

d98118a [Config] #7644 add tests for passing number looking attributes as strings
@fabpot fabpot closed this as completed Apr 20, 2013
fabpot added a commit that referenced this issue Apr 20, 2013
@fabpot
Merge branch '2.2'
1552a16 
* 2.2:
  [Config] #7644 add tests for passing number looking attributes as strings
  [HttpFoundation][BrowserKit] fixed path when converting a cookie to a string
  [BrowserKit] removed dead code
  [HttpFoundation] fixed empty domain= in Cookie::__toString()
  fixed detection of secure cookies received over https
  [2.2] Pass ESI header to subrequests
  [Translation] removed an uneeded class property
  [Translation] removed unneeded getter/setter
  [Translator] added additional conversion for encodings other than utf-8
  fixed source messages to accept pluralized messages [Validator][translation][japanese] add messages for new validator
  fix a DI circular reference recognition bug
  [HttpFoundation] fixed the creation of sub-requests under some circumstances for IIS

Conflicts:
	src/Symfony/Component/HttpFoundation/Tests/CookieTest.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Config Good first issue Ideal for your first contribution! (some Symfony experience may be required)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabpot @possi