Skip to content

[Process] Unit tests error message and slowness after merge of #8741 #8746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
romainneutron opened this issue Aug 13, 2013 · 0 comments
Closed

[Process] Unit tests error message and slowness after merge of #8741 #8746

romainneutron opened this issue Aug 13, 2013 · 0 comments

Comments

@romainneutron
Copy link
Contributor

Before the merge of #8741 :

SS...................................SS........................  63 / 170 ( 37%)
...S...............S................................S.......... 126 / 170 ( 74%)
.........................................S..

Time: 18.14 seconds, Memory: 20.00Mb

After :

SS...................................SS........................  63 / 173 ( 36%)
....S...............S........................sh: line 0: echo: write error: Broken pipe
.........S........ 126 / 173 ( 72%)
............................................S..

Time: 1.04 minutes, Memory: 108.00Mb
@romainneutron romainneutron mentioned this issue Aug 14, 2013
Merged
romainneutron added a commit to romainneutron/symfony that referenced this issue Aug 14, 2013
@romainneutron
[Process] Fix symfony#8746 : slowness added in unit tests since symfo…
8d9c7c6 
…ny#8741
fabpot added a commit that referenced this issue Aug 14, 2013
@fabpot
merged branch romainneutron/slowness (PR #8749)
b146f75 
This PR was merged into the 2.2 branch.

Discussion
----------

[Process] Fix #8746 : slowness added in unit tests since #8741

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #8746
| License       | MIT

Commits
-------

8c4bae3 [Process] Revert change
8d9c7c6 [Process] Fix #8746 : slowness added in unit tests since #8741
@fabpot fabpot closed this as completed Aug 14, 2013
fabpot added a commit that referenced this issue Aug 14, 2013
@fabpot
Merge branch '2.2' into 2.3
16413ff 
* 2.2:
  [Process] Revert change
  [Process] Fix #8746 : slowness added in unit tests since #8741
fabpot added a commit that referenced this issue Aug 14, 2013
@fabpot
Merge branch '2.3'
a67f5d0 
* 2.3:
  [Process] Revert change
  [Process] Fix #8746 : slowness added in unit tests since #8741
  [Process] Fix #8742 : Signal-terminated processes are not successful
  corrected English grammar (s/does not exists/does not exist)
  [Process] Add more precision to Process::stop timeout
  [Process] Avoid zombie process in case of unit tests failure
  [Process] Fix #8739
  [Process] Add failing test for #8739
  [Process] Fix CS
  [TwigBridge] removed superflous ; when rendering form_enctype() (closes #8660)
  Fixed documentation grammar for AuthenticationManagerInterface::authenticate()
  [Validator] fixed the wrong isAbstract() check against the class (fixed #8589)
  [TwigBridge] Prevent code extension to display warning
  Fix internal sub-request creation
  [FrameworkBundle] made code more generic
  [Form] Moved auto_initialize option to the BaseType
  Use strstr instead of strpos
  Make sure ContextErrorException is loaded during compile time errors
  Fix empty process argument escaping on Windows
  Ignore null value in comparison validators

Conflicts:
	src/Symfony/Component/Debug/Tests/ErrorHandlerTest.php
	src/Symfony/Component/HttpKernel/Tests/Fragment/InlineFragmentRendererTest.php
	src/Symfony/Component/Process/Process.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabpot @romainneutron