symfony/process - Blocked fileHandles before proc_close on Windows #8836
Labels
Comments
|
ping @romainneutron |
|
seems related to #8799 |
fabpot
added a commit
that referenced
this issue
Sep 7, 2013
This PR was squashed before being merged into the 2.2 branch (closes #8924). Discussion ---------- [Process][2.2] Fix Process component on windows | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #8836, #8799, #7078 | License | MIT This PR fixes Process on windows (almost, see note below). - Some unit tests were not Windows compatible - Use a file handle for STDERR as well as STDOUT to avoid blocking - Decouple pipes and descriptors from Process As this move some a part of Process in a sub class, I hope merging this in 2.3 and master would not be a PITA. I'm here to make some adjustments after theses merge if needed. **Important note** : We are using file handles instead of streams for `proc_open` pipes as described in the code (see [PHP bug #51800](https://bugs.php.net/bug.php?id=51800)). Unfortunately, this workaround may produce corrupted output/error output in some race conditions. That's why `AbstractProcessTest::testProcessPipes` randomly fails when using file handles (on unix and windows). Commits ------- 4a76c76 [Process][2.2] Fix Process component on windows
|
Let's check the issue is solved once #8955 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am using symfony and symfony/assetic-bundle 2.3.x-dev, Windows 7 (64b).
It looks like those file handles are not readable unless the process is closed. The fread function returns an empty string in the case it's not readable.
I've fixed it using this dirty hotfix which works for my scenario.
http://maryo.cz/files/hotfix.png
The text was updated successfully, but these errors were encountered: