[WIP][DependencyInjection] Issue #7555 - Resolve environment variables at runtime #10138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So far, the issues in the build do not seem to be linked to this PR. |
|
Can I suggest an improvement.. This run-time resolver could also resolve the parameters set via the newly introduced expression engine. |
|
This could indeed be considered, but this would be a separate PR isn’t it ? |
| @@ -25,6 +25,7 @@ | |||
| class ParameterBag implements ParameterBagInterface | |||
| { | |||
| protected $parameters = array(); | |||
| protected $environment_map = array(); | |||
There was a problem hiding this comment.
Property names should use camel case
|
Closing as it does not fix the problem in all cases (see the referenced other PR I created which also failed). |
fabpot
added a commit
that referenced
this pull request
Sep 15, 2016
…env(MY_ENV_VAR)% (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [DI] Allow injecting ENV parameters at runtime using %env(MY_ENV_VAR)% | Q | A | ------------- | --- | Branch? | master | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10138, #7555, #16403, #18155 | License | MIT | Doc PR | symfony/symfony-docs#6918 This is an alternative approach to #18155 for injecting env vars into container configurations. With this PR, anywhere parameters are allowed, one can use `%env(ENV_VAR)%` to inject a dynamic env var. Additionally, if one sets a value to such parameters in e.g. the `parameter.yml` file (`env(ENV_VAR): foo`), this value will be used as a default value when the env var is not defined. If no default value is specified, an `EnvVarNotFoundException` will be thrown at runtime. Unlike previous attempts that also used parameters (#16403), the implementation is compatible with DI extensions: before being dumped, env vars are resolved to uniquely identifiable string placeholders that can get through DI extensions manipulations. When dumped, these unique placeholders are replaced by dynamic calls to a getEnv method.. ping @magnusnordlander @dzuelke @fabpot Commits ------- bac2132 [DI] Allow injecting ENV parameters at runtime using %env(MY_ENV_VAR)% syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to set a parameter
environment_mapthat contains a map[$parameter => $env_var]. This allows to callParameterBag::resolveEnvironmentMapeven after the bag was initially resolved and frozen. As mentioned by @stof, dependent parameter can not be resolved anymore, so it is forbidden to reference a parameter in the environment map elsewhere. However,resolveEnvironmentMapwill useresolveValue, so it is possible to reference another parameter in the enviromnent variable.HttpKernelnow callsParameterBag::resolveEnvironmentMapafter theContainerwas fully loaded.I am not entirely sure of the implication of this method with the caching mechanism, the cache warmers, etc. I could use some help from someone with a better understanding of the whole thing.
The only BC break is that
environment_mapis not a valid parameter name anymore, it is reserved.