[DataCollector] Improves the readability of the collected arrays in the profiler. #10155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| { | ||
| if (is_object($value)) { | ||
| return sprintf('Object(%s)', get_class($value)); | ||
| } | ||
|
|
||
| if (is_array($value) && empty($value)) { |
There was a problem hiding this comment.
may be this should be merged with the if just below ?
There was a problem hiding this comment.
I made it this way to improve readability, but you are right.
|
Nobody want that? 😟 |
|
Can you add some tests? |
| return '[]'; | ||
| } | ||
|
|
||
| $indent = str_repeat(' ', $depth); |
There was a problem hiding this comment.
is here 2 spaces or 4 spaces better?
|
👍 it is a good idea |
|
I don't understand how it could work with just these modifications. In my test on Symfony 2.3, 2.4, and 2.5, it just did not had the expected behavior described here. So, I've made the needed changes in #10352 |
|
I have a 2.4.1 and it just works as expected. |
fabpot
added a commit
that referenced
this pull request
Mar 1, 2014
…ted arrays in the profiler (fabpot) This PR was merged into the 2.5-dev branch. Discussion ---------- [DataCollector] Improves the readability of the collected arrays in the profiler | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT This PR is based on #10155. Original description: It simply improves the readability of the collected arrays in the profiler: __before__: ``` Array(date => Array(year => , month => , day => ), time => Array(hour => )) ``` __after__: ``` [ date => [ year => , month => , day => ], time => [ hour => ] ] ``` Commits ------- dce66c9 removed double-stringification of values in the profiler 1cda2d4 [HttpKernel] tweaked value exporter 3f297ea Improves the readability of the collected arrays in the profiler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It simply improves the readability of the collected arrays in the profiler:
before:
after: