Removed old request service by new request_stack service #10249
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
deguif
commented
Feb 12, 2014
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| License | MIT |
| @@ -106,7 +106,7 @@ private function generateLogoutUrl($key, $referenceType) | |||
| $parameters = null !== $csrfTokenManager ? array($csrfParameter => (string) $csrfTokenManager->getToken($csrfTokenId)) : array(); | |||
|
|
|||
| if ('/' === $logoutPath[0]) { | |||
| $request = $this->container->get('request'); | |||
| $request = $this->container->get('request_stack')->getMasterRequest(); | |||
There was a problem hiding this comment.
Shouldn't this be getCurrentRequest()?
There was a problem hiding this comment.
I'm not sure with that but it seems that base path and some other properties from HttpFoundation/Request are set to null on sub request. This is why I use getMasterRequest()
There was a problem hiding this comment.
@deguif using the master request instead of the current request is a bahvior change
|
closing in favor of #10354 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.