-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Validator] New NodeTraverser implementation #10287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
86 commits
Select commit
Hold shift + click to select a range
25cdc68
[Validator] Refactored ValidatorTest and ValidationVisitorTest into a…
webmozart a6ed4ca
[Validator] Prototype of the traverser implementation
webmozart a40189c
[Validator] Decoupled the new classes a bit
webmozart 7e3a41d
[Validator] Moved visitors to NodeVisitor namespace
webmozart b1a9477
[Validator] Added ObjectInitializer visitor
webmozart 1156bde
[Validator] Extracted code for group sequence resolving into GroupSeq…
webmozart 321d5bb
[Validator] Throw exception if ObjectInitializer is constructed witho…
webmozart 680f1ee
[Validator] Renamed $params to $parameters
webmozart 8ae68c9
[Validator] Made tests green (yay!)
webmozart c1b1e03
[Validator] Added TODO reminder
webmozart 5fbf848
[Validator] Added note about Callback constraint to CHANGELOG
webmozart 8318286
[Validator] Completed GroupSequence implementation
webmozart f6b7288
[Validator] Removed unused use statement
webmozart 4ea3ff6
[Validator] Finished inline documentation of ExecutionContext[Interface]
webmozart adc1437
[Validator] Fixed failing tests
webmozart 499b2bb
[Validator] Completed test coverage of ExecutionContext
webmozart 405a03b
[Validator] Updated deprecation notes in GroupSequence
webmozart 9b07b0c
[Validator] Implemented BC validation of arrays through validate()
webmozart 297ba4f
[Validator] Added a note why scalars are passed to cascadeObject() in…
webmozart 09f744b
[Validator] Implemented BC traversal of traversables through validate()
webmozart ee1adad
[Validator] Implemented handling of arrays and Traversables in Legacy…
webmozart 718601c
[Validator] Changed validateValue() to validate() in the new API
webmozart feb3d6f
[Validator] Tested the validation in a separate context
webmozart 1e81f3b
[Validator] Finished test coverage and documentation of ExecutionCont…
webmozart 9c9e715
[Validator] Completed documentation of GroupManagerInterface
webmozart 2c65a28
[Validator] Completed test coverage and documentation of the Node cla…
webmozart a3555fb
[Validator] Fixed: Objects are not traversed unless they are instance…
webmozart bc29591
[Validator] Clearly separated classes supporting the API <2.5/2.5+
webmozart 26eafa4
[Validator] Removed unused use statements
webmozart df41974
[Validator] Changed context manager to context factory
webmozart e440690
[Validator] Renamed validateCollection() to validateObjects()
webmozart e057b19
[Validator] Decoupled ContextRefresher from ExecutionContext
webmozart 230f2a7
[Validator] Fixed exception message
webmozart cf1281f
[Validator] Added "Visitor" suffix to all node visitors
webmozart 94583a9
[Validator] Changed NodeTraverser to traverse nodes iteratively, not …
webmozart 117b1b9
[Validator] Wrapped collections into CollectionNode instances
webmozart 51197f6
[Validator] Made traversal of Traversables consistent
webmozart 08172bf
[Validator] Merged validate(), validateObject() and validateObjects()…
webmozart aeb6822
[Validator] Improved visitor names
webmozart 4161371
[Validator] Removed unused use statements
webmozart 76d8c9a
[Validator] Fixed typos
webmozart 778ec24
[Validator] Removed helper class Traversal
webmozart 6fc6ecd
[Validator] Fixed tests under PHP<5.3.9
webmozart 2936d10
[Validator] Removed unused use statement
webmozart e8fa15b
[Validator] Fixed the new validator API under PHP < 5.3.9
webmozart 8558377
[Validator] Added deprecation notes
webmozart dbce5a2
[Validator] Updated outdated doc blocks
webmozart 822fe47
[Validator] Completed inline documentation of the Node classes and th…
webmozart 186c115
[Validator] Improved test coverage of NonRecursiveNodeTraverser
webmozart 299c2dc
[Validator] Improved test coverage and prevented duplicate validation…
webmozart be7f055
[Validator] Visitors may now abort the traversal by returning false f…
webmozart 9986f03
[Validator] Added inline documentation for the PropertyPath utility c…
webmozart 524a953
[Validator] Improved inline documentation of the validators
webmozart 9ca61df
[Validator] Improved inline documentation of CascadingStrategy and Tr…
webmozart 01ceeda
[Validator] Improved test coverage of the Traverse constraint
webmozart 79387a7
[Validator] Improved inline documentation of the metadata classes
webmozart 987313d
[Validator] Improved inline documentation of the violation builder
webmozart 93fdff7
[Validator] The supported API versions can now be passed to the Valid…
webmozart 886e05e
[Validator] Removed unused use statement
webmozart f61d31e
[Validator] Fixed grammar
webmozart 23534ca
[Validator] Added a recursive clone of the new implementation for spe…
webmozart 38e26fb
[Validator] Decoupled RecursiveContextualValidator from Node
webmozart 274d4e6
[Validator] Changed ValidatorBuilder to always use LegacyExecutionCon…
webmozart eeed509
[Validator] Improved phpdoc of RecursiveValidator
webmozart 5c479d8
[Validator] Simplified validateNodeForGroup
webmozart eed29d8
[Validator] Improved performance of *ContextualValidator::validate()
webmozart 50bb84d
[Validator] Optimized RecursiveContextualValidator
webmozart be508e0
[Validator] Merged DefaultGroupReplacingVisitor and ContextUpdateVisi…
webmozart 1622eb3
[Validator] Fixed reference to removed class in ValidatorBuilder
webmozart 94ef21e
[Validator] Optimized use statements
webmozart 73c9cc5
[Validator] Optimized performance by calling spl_object_hash() only o…
webmozart 2f23d97
[Validator] Reduced number of method calls on the execution context
webmozart 029a716
[Validator] Moved logic of replaceDefaultGroup() to validateNode()
webmozart 3183aed
[Validator] Improved performance of cache key generation
webmozart 90c27bb
[Validator] Removed traverser implementation
webmozart 166d71a
[Validator] Removed unused property
webmozart 7bc952d
[Validator] Improved inline documentation of RecursiveContextualValid…
webmozart 1b111d0
[Validator] Fixed typos pointed out by @cordoval
webmozart 0946dbe
[Validator] Adapted CHANGELOG
webmozart 9b204c9
[FrameworkBundle] Implemented configuration to select the desired Val…
webmozart c5629bb
[Validator] Added getObject() to ExecutionContextInterface
webmozart 3dc2b4d
[Validator] Made "symfony/property-access" an optional dependency
webmozart 0bfde4a
[Validator] Fixed misnamed method calls in FrameworkExtension
webmozart b1badea
[Validator] Fixed failing CsrfFormLoginTest
webmozart 68d8018
[Validator] Documented changes in the UPGRADE files
webmozart ca6a722
[Validator] Converted `@deprecate` doc comment into regular doc comment
webmozart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"now returns a
GroupSequence
instance" ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please clarify your question?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it return a single one or multiple? The first line makes me think it returns a list of GroupSequence's but the following line talks as it returns a single instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, got it now. It returns one only, will fix :)