[HttpFoundation] json_encode options #10496
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The problem in your case would still be that the protected encodingOptions are not the same as the options that you actually use. A little strange in your class. |
|
I agree with @Tobion, the method If you extend the class, the following constructor will set the desired encoding options without recalculating the JSON value. public function __construct($data = null, $status = 200, $headers = array())
{
parent::__construct(null, $status, $headers);
$this->encodingOptions |= JSON_PRETTY_PRINT;
$this->setData($data);
} |
|
That's actually right, didn't think about it that way - thanks for the pointer :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #9915 introduced the possibility to overwrite the options we use while calling
json_encode- right now, if i want to extendJsonResponsei have to callsetEncondingOptionsin my constructor which causes the encoded string to be decoded and re-encoded again (this time using the correct/intended options).if we would rely on
getEncodingOptionsin the first place, we could save one roundtrip, since my ownJsonResponsecould definegetEncodingOptionslike this:and there would be no need to decode & re-encoding the whole thing at all - just because i would want to have pretty printed json.
WDYT?