[Validator] Added minSize option to File constraint #10507
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
megazoll
commented
Mar 20, 2014
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR | symfony/symfony-docs#3703 |
| $limit = (int) $constraintSize; | ||
| $suffix = 'MB'; | ||
| } else { | ||
| throw new ConstraintDefinitionException(sprintf('"%s" is not a valid maximum size', $constraintSize)); |
There was a problem hiding this comment.
The error message "is not a valid maximum size" is wrong when calling it for minSize (Line 130).
|
What would be the use case for that option? Do you really have a real-world usage of this where you force people to upload a file with a minimum size? |
|
@fabpot sometimes users uploading empty files. For example, when document opened in MS Office, it locked and uploads with 0 bytes. |
|
Having a way to disallow empty files make sense to me, having a min size does not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.