Skip to content

[Form] Fixed infinite tests when ICU is available #10571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Form] Fixed infinite tests when ICU is available #10571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTimeTypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,8 +433,8 @@ public function testDateTypeChoiceErrorsBubbleUp()

$form['date']->addError($error);

$this->assertSame(array(), $form['date']->getErrors());
$this->assertSame(array($error), $form->getErrors());
$this->assertSame(array(), iterator_to_array($form['date']->getErrors()));
$this->assertSame(array($error), iterator_to_array($form->getErrors()));
}

public function testDateTypeSingleTextErrorsBubbleUp()
Expand All @@ -446,8 +446,8 @@ public function testDateTypeSingleTextErrorsBubbleUp()

$form['date']->addError($error);

$this->assertSame(array(), $form['date']->getErrors());
$this->assertSame(array($error), $form->getErrors());
$this->assertSame(array(), iterator_to_array($form['date']->getErrors()));
$this->assertSame(array($error), iterator_to_array($form->getErrors()));
}

public function testTimeTypeChoiceErrorsBubbleUp()
Expand All @@ -457,8 +457,8 @@ public function testTimeTypeChoiceErrorsBubbleUp()

$form['time']->addError($error);

$this->assertSame(array(), $form['time']->getErrors());
$this->assertSame(array($error), $form->getErrors());
$this->assertSame(array(), iterator_to_array($form['time']->getErrors()));
$this->assertSame(array($error), iterator_to_array($form->getErrors()));
}

public function testTimeTypeSingleTextErrorsBubbleUp()
Expand All @@ -470,8 +470,8 @@ public function testTimeTypeSingleTextErrorsBubbleUp()

$form['time']->addError($error);

$this->assertSame(array(), $form['time']->getErrors());
$this->assertSame(array($error), $form->getErrors());
$this->assertSame(array(), iterator_to_array($form['time']->getErrors()));
$this->assertSame(array($error), iterator_to_array($form->getErrors()));
}

}
12 changes: 6 additions & 6 deletions src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,8 +745,8 @@ public function testYearErrorsBubbleUp($widget)
));
$form['year']->addError($error);

$this->assertSame(array(), $form['year']->getErrors());
$this->assertSame(array($error), $form->getErrors());
$this->assertSame(array(), iterator_to_array($form['year']->getErrors()));
$this->assertSame(array($error), iterator_to_array($form->getErrors()));
}

/**
Expand All @@ -760,8 +760,8 @@ public function testMonthErrorsBubbleUp($widget)
));
$form['month']->addError($error);

$this->assertSame(array(), $form['month']->getErrors());
$this->assertSame(array($error), $form->getErrors());
$this->assertSame(array(), iterator_to_array($form['month']->getErrors()));
$this->assertSame(array($error), iterator_to_array($form->getErrors()));
}

/**
Expand All @@ -775,8 +775,8 @@ public function testDayErrorsBubbleUp($widget)
));
$form['day']->addError($error);

$this->assertSame(array(), $form['day']->getErrors());
$this->assertSame(array($error), $form->getErrors());
$this->assertSame(array(), iterator_to_array($form['day']->getErrors()));
$this->assertSame(array($error), iterator_to_array($form->getErrors()));
}

public function testYearsFor32BitsMachines()
Expand Down
12 changes: 6 additions & 6 deletions src/Symfony/Component/Form/Tests/Extension/Core/Type/TimeTypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,8 +601,8 @@ public function testHourErrorsBubbleUp($widget)
));
$form['hour']->addError($error);

$this->assertSame(array(), $form['hour']->getErrors());
$this->assertSame(array($error), $form->getErrors());
$this->assertSame(array(), iterator_to_array($form['hour']->getErrors()));
$this->assertSame(array($error), iterator_to_array($form->getErrors()));
}

/**
Expand All @@ -616,8 +616,8 @@ public function testMinuteErrorsBubbleUp($widget)
));
$form['minute']->addError($error);

$this->assertSame(array(), $form['minute']->getErrors());
$this->assertSame(array($error), $form->getErrors());
$this->assertSame(array(), iterator_to_array($form['minute']->getErrors()));
$this->assertSame(array($error), iterator_to_array($form->getErrors()));
}

/**
Expand All @@ -632,8 +632,8 @@ public function testSecondErrorsBubbleUp($widget)
));
$form['second']->addError($error);

$this->assertSame(array(), $form['second']->getErrors());
$this->assertSame(array($error), $form->getErrors());
$this->assertSame(array(), iterator_to_array($form['second']->getErrors()));
$this->assertSame(array($error), iterator_to_array($form->getErrors()));
}

/**
Expand Down