[DependencyInjection] added a simple way to replace a service by keeping a reference to the old one #10600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
your PR conflicts. Can you rebase it ? |
…ing a reference to the old one
|
Rebased |
5 tasks
| public function setDecoratedService($id, $renamedId = null) | ||
| { | ||
| if ($renamedId && $id == $renamedId) { | ||
| throw new \LogicException(sprintf('The decorated service inner name for "%s" must be different than the service name itself.', $id)); |
There was a problem hiding this comment.
I would use InvalidArgumentException
|
I've added unit test and dumpers / loaders |
| * | ||
| * @throws InvalidArgumentException In case the decorated service id and the new decorated service id are equals. | ||
| */ | ||
| public function setDecoratedService($id, $renamedId = null) |
There was a problem hiding this comment.
this method currently does not allow to reset it. We should find a way to do it (maybe passing null as id) as we will need to do it
|
PR updated, @stof comments addressed |
| if (!$decorated = $definition->getDecoratedService()) { | ||
| continue; | ||
| } | ||
| $definition->setDecoratedService(null); |
There was a problem hiding this comment.
https://github.com/symfony/symfony/pull/10600/files#r11152517 has been addressed here
fabpot
added a commit
that referenced
this pull request
Apr 1, 2014
…service by keeping a reference to the old one (romainneutron) This PR was merged into the 2.5-dev branch. Discussion ---------- [DependencyInjection] added a simple way to replace a service by keeping a reference to the old one | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #5920 | License | MIT | Doc PR | symfony/symfony-docs#3745 This PR replaces #9003. Here's the todo list: - [x] add a cookbook entry for this new feature - [x] add support in all loaders/dumpers - [x] add unit tests - [x] see if there are use cases in Symfony that would benefit from this new feature - [x] find the best name for this feature I've implemented YAML and XML Loader / Dumper. From what I see, PhpDumper, PhpLoader, IniLoader, GraphvizDumper do not require an update, am I wrong? Commits ------- 140f807 [DependencyInjection] Update dumpers and loaders, add unit tests 1eb1f4d [DependencyInjection] added a simple way to replace a service by keeping a reference to the old one
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this pull request
May 29, 2014
…ecoration (romainneutron) This PR was submitted for the master branch but it was merged into the 2.5 branch instead (closes #3753). Discussion ---------- [DependencyInjection] Add documentation about service decoration | Q | A | ------------- | --- | Doc fix? | yes | New docs? | yes (symfony/symfony#10600) | Applies to | 2.5+ | Fixed tickets | #3745 Commits ------- 578d2e2 [DependencyInjection] Add documentation about service decoration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #9003. Here's the todo list:
I've implemented YAML and XML Loader / Dumper.
From what I see, PhpDumper, PhpLoader, IniLoader, GraphvizDumper do not require an update, am I wrong?