[Security] Replace exception mocks with actual exception instances. #10621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is done for two reasons: * consistency - we use real exception objects in most of the code * latest phpunit does not like the way we were creating mocks for exceptions (it could be also fixed by letting phpunit to call the original constructor)
| @@ -129,7 +129,7 @@ protected function getAuthenticationProvider($supports, $token = null, $exceptio | |||
| } elseif (null !== $exception) { | |||
| $provider->expects($this->once()) | |||
| ->method('authenticate') | |||
| ->will($this->throwException($this->getMock($exception, null, array(), '', false))) | |||
| ->will($this->throwException($this->getMock($exception, null, array(), '', true))) | |||
There was a problem hiding this comment.
could we pass a real exception instead of a classname?
There was a problem hiding this comment.
Not in this specific case, since one of the exception classes here is abstract (Symfony\Component\Security\Core\Exception\AccountStatusException).
fabpot
added a commit
that referenced
this pull request
Apr 3, 2014
… instances. (jakzal) This PR was merged into the 2.3 branch. Discussion ---------- [Security] Replace exception mocks with actual exception instances. It is done for two reasons: * consistency - we use real exception objects in most of the code * latest phpunit does not like the way we were creating mocks for exceptions (it could be also fixed by letting phpunit to call the original constructor) Commits ------- 9438f88 [Security] Replace exception mocks with actual exception instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is done for two reasons: