[Console] added a Process helper #10627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| OUT 42 | ||
| RES Command ran successfully | ||
| '; | ||
| $successOutputProcessDebug = ' RUN \'php\' \'-r\' \'echo 42;\' |
There was a problem hiding this comment.
couldn't it be clearer if you use EOT<<< syntax?
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this pull request
Apr 12, 2014
…neutron) This PR was merged into the master branch. Discussion ---------- [WCM][Console] Add Process Helper documentation | Q | A | ------------- | --- | Doc fix? | yes | New docs? | yes (symfony/symfony#10627) | Applies to | 2.5+ | Fixed tickets | n/a Commits ------- 1705231 [Console] Add Process Helper documentation
| $process = $this->run($output, $cmd, $error, $callback); | ||
|
|
||
| if (!$process->isSuccessful()) { | ||
| throw new ProcessFailedException($process); |
There was a problem hiding this comment.
There was a problem hiding this comment.
however, the use statement is indeed missing
|
hello, sorry for the delay. I've just update the PR. It should be okay now. |
| @@ -5,11 +5,14 @@ CHANGELOG | |||
| ----- | |||
|
|
|||
| * deprecated the dialog helper (use the question helper instead) | |||
| * added a Process helper | |||
| * added a DebugFormatter helper | |||
There was a problem hiding this comment.
Those changes can't land in 2.5 as it was already released, it can land only in 2.6+.
There was a problem hiding this comment.
That's right :) it's fixed
|
👍 |
|
... but tests do not pass :( |
|
@fabpot I've fixed the console tests |
|
👍 |
fabpot
added a commit
that referenced
this pull request
Jun 11, 2014
This PR was merged into the 2.3-dev branch. Discussion ---------- [Console] added a Process helper | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | symfony/symfony-docs#3930 This PR replaces #10609. I've fixed minor errors, added tests and allowed to pass an array of arguments to escape as a command Commits ------- edc1bfe [Console] Add process helper tests faffe7e [Console] added a Process helper
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 17, 2014
This PR was merged into the master branch. Discussion ---------- [Console] Add Process Helper documentation | Q | A | ------------- | --- | Doc fix? | yes | New docs? | yes (symfony/symfony#10627) | Applies to | 2.5+ | Fixed tickets | n/a This PR replaces #3756 (merged prematurely) Commits ------- a9d6a8b [Console] Add Process Helper documentation
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this pull request
Dec 16, 2014
…uterJ) This PR was merged into the 2.6 branch. Discussion ---------- Added documentation about the DebugFormatter helper | Q | A | --- | --- | Doc fix? | no | New docs? | yes (symfony/symfony#10627) | Applies to | 2.6+ | Fixed tickets | #4256 When may want to add screenshots to the article, but to get this ready quick before 2.6 is released stable, I left them out now. Commits ------- 99f31fc Reordered list of helpers 6a02f68 Applied comments from our great reviewers 363e38f Added documentation about the DebugFormatter helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #10609.
I've fixed minor errors, added tests and allowed to pass an array of arguments to escape as a command