[Security] Call AuthenticationManager in AnonymousAuthenticationListener #10694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cakper
commented
Apr 11, 2014
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #10651 |
| License | MIT |
| Doc PR | - |
|
ping @jakzal what shall I do about it? :) |
|
Looks good to me and I would indeed merge it in master only. 👍 ping @symfony/deciders |
|
Thank you @cakper. |
fabpot
added a commit
that referenced
this pull request
Sep 25, 2014
…enticationListener (Kacper Gunia) This PR was merged into the 2.6-dev branch. Discussion ---------- [Security] Call AuthenticationManager in AnonymousAuthenticationListener | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10651 | License | MIT | Doc PR | - Commits ------- 78fa5e2 Call AuthenticationManager in AnonymousAuthenticationListener
|
Thanks Fabien :) good to have it fixed On Thu, Sep 25, 2014 at 9:11 AM, Fabien Potencier
|
romainneutron
added a commit
to romainneutron/symfony
that referenced
this pull request
Sep 26, 2014
fabpot
added a commit
that referenced
this pull request
Sep 27, 2014
…ron) This PR was merged into the 2.6-dev branch. Discussion ---------- [Security] Fix BC break introduced in #10694 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12034 | License | MIT Not sure about this fix, @stof 'ing welcome Commits ------- b2183aa [Security] Fix BC break introduces in #10694
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.