[ConfigCache] Use non-local files resources #10761
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| $this->container = $container; | ||
| $this->loaderIds = $loaderIds; | ||
|
|
||
| if ($this->container->has($refresherId)) { | ||
| $this->refresher = $this->container->get($refresherId); | ||
| } |
There was a problem hiding this comment.
This does not make sense. If you don't lazy-load the refresher, you should inject it directly instead of injecting a service id
There was a problem hiding this comment.
OK, as we already have the container, it seemed strange to inject one more object....
But I will change this.
|
After talking with @iamluc about this PR, I'm going to close it as this is a use case I don't want to support. To make a long story short, the ConfigCache class should only be used for resources that do need to be checked for changes after they are compiled. So, the concept of a mutable resource is out of this scope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is another try to use non-local file resources in ConfigCache, like #7230
There are 2 main changes:
The metafile is now created if at least one resource is mutable, and not according to the debug flag like before.
It serves for example to reinject the database connexion after unserializing ressources
Compatibility should be maintained.
TODO: