[Process] Disable TTY mode on Windows platform #10763
Merged
+20
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
romainneutron
commented
Apr 22, 2014
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| License | MIT |
|
doesn't this require a testsuite change ? |
|
Updated, added a test on Windows platform |
| */ | ||
| public function setTty($tty) | ||
| { | ||
| if (defined('PHP_WINDOWS_VERSION_BUILD')) { |
There was a problem hiding this comment.
you should throw the exception only when trying to set it to true, not when setting it to false.
|
@stof I've addressed your comment |
|
👍 |
| */ | ||
| public function setTty($tty) | ||
| { | ||
| if (defined('PHP_WINDOWS_VERSION_BUILD') && $tty) { | ||
| throw new RuntimeException('TTY mode is not supported on Windows platform.'); |
There was a problem hiding this comment.
should be a LogicException rather than a RuntimeException IMO
There was a problem hiding this comment.
I've been hesitating but I chose RuntimeException because we're already using this one in case Process::signal is called whereas the PHP has been compiled with --enable-sigchild
There was a problem hiding this comment.
I don't think there is an error of logic in this case, it's just the platform does not support it
|
Thank you @romainneutron. |
fabpot
added a commit
that referenced
this pull request
Apr 24, 2014
…ron) This PR was merged into the 2.3 branch. Discussion ---------- [Process] Disable TTY mode on Windows platform | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Commits ------- 7942c2a [Process] Disable TTY mode on Windows platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.