[HttpFoundation] Allow File instance to be passed to BinaryFileResponse #10797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
given that it is a subclass of |
|
Thanks, fixed that. |
|
Oops, yes. Pushed again now. |
| * @param null|string $contentDisposition The type of Content-Disposition to set automatically with the filename | ||
| * @param bool $autoEtag Whether the ETag header should be automatically set | ||
| * @param bool $autoLastModified Whether the Last-Modified header should be automatically set | ||
| * @param File|\SplFileInfo|string $file The file to stream |
There was a problem hiding this comment.
As @stof mentioned in the comments, you can remove the type hint on File here as it extends SplFileInfo (same below.)
|
Thank you @anlutro. |
fabpot
added a commit
that referenced
this pull request
Apr 28, 2014
…yFileResponse (anlutro) This PR was merged into the 2.3 branch. Discussion ---------- [HttpFoundation] Allow File instance to be passed to BinaryFileResponse | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10608 | License | MIT | Doc PR | See #10608 for discussion and reasoning. The docblocks get rather long with this change. The File class does extend SplFileObject so technically it could be left out of the docblock if that is more desirable. Commits ------- fc04ad2 Allow File instance to be passed to BinaryFileResponse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10608 for discussion and reasoning.
The docblocks get rather long with this change. The File class does extend SplFileObject so technically it could be left out of the docblock if that is more desirable.