[DomCrawler] Empty select with attribute name="foo[]" bug fix #10808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have a select with attribute name="foo[]", and you submit your form, http_build_query returns empty string as a result. In this case you get a form extra field validation error, because your field "foo" converts to '' => bool(false)
|
this can't be accepted without a test reproducing the issue to prevent regressions |
|
@darles Can you add some tests? |
defrag
added a commit
to defrag/symfony
that referenced
this pull request
Jun 6, 2014
Closed
defrag
added a commit
to defrag/symfony
that referenced
this pull request
Jun 6, 2014
fabpot
added a commit
that referenced
this pull request
Jun 6, 2014
…fix (darles) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #10808). Discussion ---------- [DomCrawler] Empty select with attribute name="foo[]" bug fix If you have a select with attribute name="foo[]", and you submit your form, http_build_query returns empty string as a result. In this case you get a form extra field validation error, because your field "foo" converts to '' => bool(false) Commits ------- 15f081d Empty select with attribute name="foo[]" bug fix
fabpot
pushed a commit
that referenced
this pull request
Jun 6, 2014
fabpot
added a commit
that referenced
this pull request
Jun 6, 2014
…0808 crawler test (defrag) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #11066). Discussion ---------- #10808 crawler test Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets |#10808 | License | MIT Adds test for #10808 Commits ------- 876d6ca issue #10808 crawler test
fabpot
added a commit
that referenced
this pull request
Jun 12, 2014
* 2.3: Minor doc fix. Simplified the way to update PHPUnit to the latest version [Process] Minor README update [HttpFoundation] Basic auth in url is broken when using PHP CGI/FPM Fixed a html error "Element ul is not closed" in logger.html.twig [HttpFoundation] Officialize the 308 redirect RFC issue #10808 crawler test Empty select with attribute name="foo[]" bug fix Fixed contextually wrong translation
fabpot
added a commit
that referenced
this pull request
Jun 12, 2014
* 2.4: Minor doc fix. Simplified the way to update PHPUnit to the latest version [Process] Minor README update [HttpFoundation] Basic auth in url is broken when using PHP CGI/FPM Fixed a html error "Element ul is not closed" in logger.html.twig [HttpFoundation] Officialize the 308 redirect RFC Officialize the 308 redirect RFC issue #10808 crawler test Empty select with attribute name="foo[]" bug fix Fixed contextually wrong translation
fabpot
added a commit
that referenced
this pull request
Jun 12, 2014
* 2.5: Minor doc fix. Simplified the way to update PHPUnit to the latest version [Debug] work-around https://bugs.php.net/61272 [Debug] simplify code path to remove potential blank pages [Process] Minor README update [HttpFoundation] Basic auth in url is broken when using PHP CGI/FPM Fixed a html error "Element ul is not closed" in logger.html.twig [HttpFoundation] Officialize the 308 redirect RFC Officialize the 308 redirect RFC issue #10808 crawler test Empty select with attribute name="foo[]" bug fix Fixed contextually wrong translation
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
* 2.3: Minor doc fix. Simplified the way to update PHPUnit to the latest version [Process] Minor README update [HttpFoundation] Basic auth in url is broken when using PHP CGI/FPM Fixed a html error "Element ul is not closed" in logger.html.twig [HttpFoundation] Officialize the 308 redirect RFC issue symfony#10808 crawler test Empty select with attribute name="foo[]" bug fix Fixed contextually wrong translation
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
* 2.4: Minor doc fix. Simplified the way to update PHPUnit to the latest version [Process] Minor README update [HttpFoundation] Basic auth in url is broken when using PHP CGI/FPM Fixed a html error "Element ul is not closed" in logger.html.twig [HttpFoundation] Officialize the 308 redirect RFC Officialize the 308 redirect RFC issue symfony#10808 crawler test Empty select with attribute name="foo[]" bug fix Fixed contextually wrong translation
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
* 2.5: Minor doc fix. Simplified the way to update PHPUnit to the latest version [Debug] work-around https://bugs.php.net/61272 [Debug] simplify code path to remove potential blank pages [Process] Minor README update [HttpFoundation] Basic auth in url is broken when using PHP CGI/FPM Fixed a html error "Element ul is not closed" in logger.html.twig [HttpFoundation] Officialize the 308 redirect RFC Officialize the 308 redirect RFC issue symfony#10808 crawler test Empty select with attribute name="foo[]" bug fix Fixed contextually wrong translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a select with attribute name="foo[]", and you submit your form, http_build_query returns empty string as a result. In this case you get a form extra field validation error, because your field "foo" converts to
'' => bool(false)